Mark Wilkinson
Forum Replies Created
-
Forum: Plugins
In reply to: [Better Core Video Embeds] No “alt” for imagesI have just released version 1.1.3 of the plugin which adds an empty
alttag to the thumbnail.Having done some research I think this is best solution for now.
Forum: Plugins
In reply to: [Better Core Video Embeds] Enable https://youtube.com without wwwVersion 1.1.3 (released just now) of the plugin should correct this issue. I am going to mark this as resolved.
Forum: Plugins
In reply to: [Better Core Video Embeds] Enable https://youtube.com without wwwI think you are right and it makes sense to included the non www versions. These were not include originally as copying the address from Youtube always adds the www.
However since the embed works with the www it makes sense to make this work too. I will add this into the next release.
Forum: Plugins
In reply to: [Better Core Video Embeds] No “alt” for imagesYou make a very valid point here however, what should the alt text be for the images? The reason this is difficult is that the oEmbed iFrame that is returned from the oEmbed service doesn’t contain the video title at all.
The only thing we have is the video ID and the video service name (e.g. Youtube). To get the title would require some sort of integration with the Youtube API which I would rather avoid as it gets complicated for users.
I you have any further ideas on what the alt attribute value should be then I would love to hear them please.
Forum: Reviews
In reply to: [Better Core Video Embeds] What i’ve been searching for some time…Hi there,
Thank you so much for the positive review – I am really pleased that you are finding the plugin useful.
With regards to the additional SEO words, I am always cautious about mentioning that fact the plugin could help with GDPR as it was not built for that purpose and probably doesn’t do a good enough job.
It still has to contact the Youtube servers in order to grab the thumbnail and therefore it is not going to be a complete cookie free solution. Therefore I am wary about suggesting it is so.
That said, it does use the Youtube no cookie domain for the embed and therefore I could certainly think about adding that in the description.
Thanks again for using the plugin and leaving such as a positive review.
Kind regards,
MarkForum: Plugins
In reply to: [Better Core Video Embeds] CSS isn’t being loadedThis should now be fixed with version 1.1 released just now.
Forum: Plugins
In reply to: [Better Core Video Embeds] CSS isn’t being loadedHi Mark,
Thanks for testing – I managed to recreate this. I think it stems from the hook being using to register the style.
I have now amended this and it is working for me in my tests.
Would you be so kind as the test the development branch of the plugin please to make sure this fixes the error?
https://github.com/highrisedigital/better-core-video-embeds/tree/develop
It should also correct the max width CSS issue you mentioned. If it is working for you I can then be more confident in releasing the next version with these fixes.
Thanks in advance.
Forum: Plugins
In reply to: [Better Core Video Embeds] CSS isn’t being loadedIt is the
wp_print_stylesfunction which is used:I have added the width suggestion to an issue on Github and I will get that out in a bug fix asap.
When you say:
> Also, the modified HTML uses the class name
wp-block-imagefor the replaced embed block: is this intentional?I assume you mean the
<figure>which wraps the thumbnail image from either Youtube or Vimeo?e.g.
<figure class="wp-block-image hd-bcve-wrapper wp-embed-aspect-16-9 wp-has-aspect-ratio" data-id="ckGngnqN7Z0">If so that is intentional so it will be styled like an image.
Forum: Plugins
In reply to: [Better Core Video Embeds] CSS isn’t being loadedHi Mark,
All great points – thanks for the feedback. I am really not sure why the CSS isn’t loading.
It is called with
wp_print_stylesinside the block output. I have just tested this on a test site, downloading from ww.wp.xz.cn and activating and it is loading the styles fine for me 🤔Your idea about adding
max-width: 100%;seems to make sense to me. Are there any downsides to that you can think of? Also should that be declared before or aftermax-width: 100%;?Forum: Plugins
In reply to: [WP Broadbean] PHP errors causing job posted status issues in BroadbeanHi Seb,
As this is an outdated plugin now, we don’t provide support for the plugin. However, you have a PHP fatal error referencing something in the plugins
/inc/functions.phpfile.I can’t see the line number but my guess is that you are trying to save to a non existing taxonomy.
If you are looking for a paid for, support integration service. please take a look at JobRelay.
Forum: Plugins
In reply to: [WP Broadbean] Support for hidden Broadbean salaryThe plugin does not support the “hidden” salary out of the box.
Forum: Plugins
In reply to: [WP Broadbean] Email Receipts> Can you tell me , once a client submits a job application, are they supposed to get a email receipt to say they have applied etc ?
The plugin does not send candidate notifications, only notifications to the applicant tracking email address.
You could write your own function hooked into
wpbb_application_processing_completein order to send a notification to the client too.Forum: Plugins
In reply to: [WP Broadbean] Links not in Job DescriptionThere is no setting that strips these out and they should not be stripped. The description is run through the
wp_kses_post()which should allow links.Hi Priscilla,
Thanks so much for getting back to me so quickly – I really appreciate you trying to help.
I have created a test environment locally to test this out in a more controlled install of WordPress.
I have a fresh install of WordPress 5.7 running the Twenty Twenty One theme and just the Yoast SEO plugin installed, nothing else.
I then have the following code running, as a single file in the
mu-pluginsfolder.https://gist.github.com/wpmark/effd64687c09f62987d24e317fbccbab
I have added
paragraph.cssandimage.cssto the active theme in the correct locations referenced in themu-plugin.With the Yoast SEO plugin turned on, I don’t get a
paragraph.cssfile link output above paragraph blocks, but I do get animage.cssfile rendered.Deactivating Yoast SEO means the functionality works as it should.
There are no PHP error or JS errors in the console.
It is like the paragraph block is already rendered before the page is rendered and therefore it on that pass of the
render_blockfilter that my code has actioned.- This reply was modified 5 years, 2 months ago by Mark Wilkinson.
Forum: Plugins
In reply to: [WP Broadbean] endpoint url gives me 404 page not found errorPlease try refreshing your sites permalinks in the WordPress admin. Visit Settings > Permalinks and just click save.