@hbaumhardt – That is not a change we have made, sounds like something else is going on here. We would never modify your selectors.
Also of note is that popmake-popup-request is not a valid selector to begin with and would never work as is. You would either need to add the . or # to signify if it was a class or id .popmake-popup-request | #popmake-popup-request
As for modifying the data, v1.5 didn’t even include a migration routine to change that data, and with over 35k downloads this week you would have seen dozens of other users reporting this same issue.
What that tells me isn’t necessarily that our plugin didn’t break it (it didn’t in this case because there are no functionality to modify that field in any way), but that it is not a typical occurrence and if something did happen it may be impossible to track down if you / we can’t repeat it.
But just for clarification in case it does happen to someone else, are you saing that when you edit your click triggers now they show popmake-popmake- or are you saying that they contain just popmake-popup-request but you had to add the extra popmake- to get it working.
PS if your popups name is “Popup Request” then there was never a need to add those custom selectors. To be clear, from v1 a popup could be triggered with .popmake-123 or .popmake-popup-name. So you may be simply adding a class that will already be targeted. We also now target .pum-123 & .pum-popup-name. All of this is done automatically for every popup with a click trigger. Extra selectors are just that, extra beyond these.
Hope that helps.
How odd upgrading 1.4.21 to 1.5.5 the name of the popup changed which looks like the cause of the extra popmake- in the css class.
version | popup name | popup selector | css class
1.4.21 | popup-request | popmake-popup-request | popmake-popup-request
1.5.5 | popmake-popup-request | popmake-popup-request | popmake-popmake-popup-request
I have renamed the popup to popup-request and all is fine.
As an aside the popup has been working fine for months “as is” with no extra dots or hashes in the name, inspect the green [Online demonstration request] button at http://www.matter-center.com =
avia-button-wrap avia-button-center avia-builder-el-26 avia-builder-el-no-sibling popmake-popup-request pum-trigger
Infact the custom CSS class used by the Enfold theme button does not allow dots or hashes anyway: “Custom Css Class Add a custom css class for the element here. Make sure to only use allowed characters (latin characters, underscores, dashes and numbers)”
@hbaumhardt
Infact the custom CSS class used by the Enfold theme button does not allow dots or hashes anyway: “Custom Css Class Add a custom css class for the element here. Make sure to only use allowed characters (latin characters, underscores, dashes and numbers)”
This is referring to the Enfold (or any theme builder) CSS Class field, I know this feature is found in the Advanced Tab of Beaver Builder, when editing/creating elements using your theme builder.
These fields only allow CSS Classes, which means you wouldn’t put the ., as that’s all the field will accept, as noted above.
We’re referring to the Custom CSS Selector Field in Popup Maker, found when you create a Trigger, most usually a Click Trigger.
Unlike CSS Class Fields in theme builders, our field accepts # and ., divs and classes.
Not sure if there was any confusion, as the issue is fixed, just wanted to say this anyway.
If you’re enjoying our product, please do take a moment to click that our plugin Works and to rate and review the plugin to spread the love! <3
