1.9.3.1 Tax Bug
-
Hi Folks-
I just updated to 1.9.3.1 on a U.S. based site & started testing. The state tax (Texas, 8.25%) is being applied to any state I’ve selected. This in both the shipping calculator an in the cart.
As a temporary fix I’ve substituted an older
jigoshop_tax.class.phpfile (1.8.1) and it seems to have fixed it for now.I’ll do some comparing between the 2 & see if I can isolate the offending code. In the meantime I thought I’d see if anyone else has seen the same thing.
Thanks
Karl
-
thanks for letting us know, we’ll check it out on our end too.
can you post here or via [email protected] your system info and some screen of your tax config?Sure
### Begin System Info ### Multi-site: No SITE_URL: http://www.hagstornadobait.com HOME_URL: http://www.hagstornadobait.com Jigoshop Version: 1.9.3.1 WordPress Version: 3.9.1 Platform: Windows Browser Name: Chrome Browser Version: 34.0.1847.137 User Agent String: Mozilla/5.0 (Windows NT 6.1) App leWebKit/537.36 (KHTML, like Gec ko) Chrome/34.0.1847.137 Safari/ 537.36 PHP Version: 5.4.22 MySQL Version: 5.1.73 Web Server Info: Apache/2.2.25 (Unix) mod_ssl/2.2.25 OpenSSL/0.9.8e-fips-rhel5 mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635 PHP Memory Limit: 256M PHP Post Max Size: 100MB PHP Upload Max File Size: 100MB WP_DEBUG: Disabled WP Table Prefix: Length: 3 Status: Acceptable Show On Front: page Page On Front: 8 Page For Posts: 0 Session: Enabled Session Name: PHPSESSID Cookie Path: / Save Path: /tmp Use Cookies: On Use Only Cookies: On WordPress Memory Limit: 256MB WP_DEBUG: Off DISPLAY ERRORS: N/A FSOCKOPEN: Your server supports fsockopen. ACTIVE PLUGINS: AdRotate: 3.9.13 Author Category: 0.8 BulletProof Security: .50.1 CCS-HTTPS: 1.0.0 Custom Meta Widget: 1.4.6 Email Users: 4.6.7 Fast Secure Contact Form: 4.0.19 Jigoshop: 1.9.3.1 NextGEN Gallery by Photocrati: 2.0.65 Ninja Pages, Categories, and Tags: 1.3.2 Premium Shipping for Jigoshop: 1.3.1 Regenerate Thumbnails: 2.2.4 Shadowbox JS: 3.0.3.10.2 Simple Page Ordering: 2.2 Store Locator Plus: 4.1.18 Theme My Login: 6.3.9 TinyMCE Advanced: 4.0.2 WordPress SEO: 1.5.3.2 CURRENT THEME: Atahualpa: 3.7.15 ### End System Info ###Screenshots emailed
I tested your scenario and I don’t have issues you mentioned – Jigoshop properly adds tax for only one state.
Do you have set up some other specific settings? Restriction to countries, base country etc? If you can – please mail admin access to [email protected] we will try to recreate the exact instance to test.
Yes, it is restricted to U.S. only with United States – Texas as base country/region.
I’ll be troubleshooting later, deactivating the ton of plugins & debugging, and post back here later. If I hit a wall I’ll certainly create an admin account for you.
Thanks
KarlHi,
Getting the same bug. Here is my system info.
### Begin System Info ###
Multi-site: No
SITE_URL: http://www.xcvi.com
HOME_URL: http://www.xcvi.comJigoshop Version: 1.9.3.1
WordPress Version: 3.9.1Platform: Apple
Browser Name: Firefox
Browser Version: 29.0
User Agent String: Mozilla/5.0 (Macintosh; Intel Ma
c OS X 10.9; rv:29.0) Gecko/2010
0101 Firefox/29.0PHP Version: 5.3.27
MySQL Version: 5.5.36
Web Server Info: Apache/2.4.6 (Unix) OpenSSL/1.0.0-fips mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635PHP Memory Limit: 256M
PHP Post Max Size: 52MB
PHP Upload Max File Size: 52MBWP_DEBUG: Disabled
WP Table Prefix: Length: 9 Status: Acceptable
Show On Front: page
Page On Front: 2367
Page For Posts: 2000Session: Enabled
Session Name: PHPSESSID
Cookie Path: /
Save Path: /tmp
Use Cookies: On
Use Only Cookies: OnWordPress Memory Limit: 256MB
WP_DEBUG: Off
DISPLAY ERRORS: On (1)
FSOCKOPEN: Your server supports fsockopen.ACTIVE PLUGINS:
Akismet: 3.0.0
AnythingSlider for WordPress: 0.6.8
Breadcrumb NavXT: 5.0.1
Comprehensive Google Map Plugin: 9.0.20
Constant Contact Widget 2.0: 2.0.3
Delete Pending Comments: 0.2.1.1
Easing Slider “Pro”: 2.0.5.1
Google Analytics for WordPress: 4.3.5
Gravity Forms: 1.8.8
Headway Connect for Jigoshop: 1.0
iframe: 2.8
iThemes Security: 4.2.4
Jigoshop: 1.9.3.1
Jigoshop – Orders & Clients CSV Export: 1.0.1
Jigoshop – Product CSV Suite: 2.0.2
Jigoshop: Authorize.net Gateway: 1.1
Jigoshop Filtering Premium: 2.4.6
Jigoshop Google Product Feed: 1.9
Jigoshop PDF Invoices: 2.2
JigoShop Per Product Shipping: 1.0.10
Magic Zoom Plus for Jigoshop: 5.9.5
ManageWP – Worker: 3.9.29
Quick Page/Post Redirect Plugin: 5.0.6
Regenerate Thumbnails: 2.2.4
Search Everything: 8.1.1
SimpleMap: 2.4.6
Simple Page Ordering: 2.2
Smart Google Analytics Code: 3.4
SOD QuickBooks Connector: 1.0
SSL Insecure Content Fixer: 1.8.0
TinyMCE Advanced: 4.0.2
Twitter for WordPress: 1.9.7
Velvet Blues Update URLs: 3.2.2
Vixy YouTube Embed: 3.2
W3 Total Cache: 0.9.4
WordPress HTTPS: 3.3.6
WordPress SEO: 1.5.3.2
WP-Mail-SMTP: 0.9.4
WP-SimpleViewer: 2.3.2.2CURRENT THEME:
XCVI Headway Child Theme Template: 1.0
### End System Info ###
Same issue here. In my case, in the tax settings I set to Minnesota, after clicking save *all* U.S. states are added. Using an older version of jigoshop_tax.class.php fixes the issue.
System Info:
### Begin System Info ###
Multi-site: No
SITE_URL: ***
HOME_URL: ***Jigoshop Version: 1.9.2
WordPress Version: 3.9.1Platform: Apple
Browser Name: Safari
Browser Version: 7.0.3
User Agent String: Mozilla/5.0 (Macintosh; Intel Ma
c OS X 10_9_3) AppleWebKit/537.7
5.14 (KHTML, like Gecko) Version
/7.0.3 Safari/537.75.14PHP Version: 5.4.4-14+deb7u9
MySQL Version: 5.5.37-0+wheezy1
Web Server Info: Apache/2.2.22 (Debian)PHP Memory Limit: 256M
PHP Post Max Size: 8MB
PHP Upload Max File Size: 2MBWP_DEBUG: Enabled
WP Table Prefix: Length: 3 Status: Acceptable
Show On Front: posts
Page On Front: 0
Page For Posts: 0Session: Enabled
Session Name: PHPSESSID
Cookie Path: /
Save Path: /var/lib/php5
Use Cookies: On
Use Only Cookies: OnWordPress Memory Limit: 40MB
WP_DEBUG: On
DISPLAY ERRORS: On (1)
FSOCKOPEN: Your server supports fsockopen.ACTIVE PLUGINS:
bbPress: 2.5.3
Jigoshop: 1.9.2CURRENT THEME:
Euston Square: 1.0
### End System Info ###
Hi,
does your theme has “jigoshop” directory? or functions overwriting jigoshop functionalities in functions.php?
that’s most commont reason of these issues.optart –
Good call! I disabled a couple functions in the functions.php file and the taxes started working again. I’ll remember this next time.
Thanks again for the help!
@dustyfields
which functions were interfering with it? I’m set to california and it does it as well. i reported the issue but never got a resolution.About the only modded files I’m currently running are
jigoshop_template_actions.php where I change add_action to remove_action for the jigoshop_sidebar
and
Atahualpa’s footer.php
if (!isset($bfa_ata))
to
if ((!isset($bfa_ata)) or (class_exists('jigoshop')) )
both for layout control.I’m just now getting back into troubleshooting, the site’s been working on the old tax class for now.
More later
Disabling all plugins except Jigoshop doesn’t affect the tax bug.
A difference between the old tax class & the new is the absence of the “end” in the syntax of the control structure. Example:
1.9.3.1
public static function get_taxes_as_array($taxes_as_string, $tax_divisor = -1){ $tax_classes = array(); if($taxes_as_string){ $taxes = explode('|', $taxes_as_string); foreach($taxes as $tax){ @list($tax_class, $tax_info) = explode(':', $tax); if($tax_info !== null){ $tax_info = explode(',', $tax_info); foreach($tax_info as $info){ $value = explode('^', $info); if(in_array($value[0], array('rate', 'display', 'compound'))){ $tax_classes[$tax_class][$value[0]] = (sizeof($value) > 1 ? ($value[0] == 'compound' && $value[1] == null ? false : $value[1]) : ($value[0] == 'compound' ? false : '')); } else { $tax_classes[$tax_class][$value[0]] = (sizeof($value) > 1 ? ($tax_divisor > 0 ? $value[1] / $tax_divisor : $value[1]) : ''); } } } } } return $tax_classes; }1.8.1
public static function get_taxes_as_array($taxes_as_string, $tax_divisor = -1) { $tax_classes = array(); if ($taxes_as_string) : $taxes = explode('|', $taxes_as_string); foreach ($taxes as $tax) : $tax_class = explode(':', $tax); if (isset($tax_class[1])) : $tax_info = explode(',', $tax_class[1]); if (isset($tax_class[0])) : foreach ($tax_info as $info) : if (isset($info)) : $key_value = explode('^', $info); if ($key_value[0] == 'rate' || $key_value[0] == 'display' || $key_value[0] == 'compound') : $tax_classes[$tax_class[0]][$key_value[0]] = (sizeof($key_value) > 1 ? ($key_value[0] == 'compound' && $key_value[1] == null ? false : $key_value[1]) : ($key_value[0] == 'compound' ? false : '')); else : $tax_classes[$tax_class[0]][$key_value[0]] = (sizeof($key_value) > 1 ? ($tax_divisor > 0 ? $key_value[1] / $tax_divisor : $key_value[1]) : ''); endif; endif; endforeach; endif; endif; endforeach; endif; return $tax_classes; }That is throughout the file on every function. I’m just a php hack, not sure how relevant that is. But in my mind that could be taxing all states?
Thanks
KarlKarl,
Great fix. Just replace the tax class file. Everything is working again.
missed out on the week’s sales taxes – o well, should have thought it up my self.I’m sure jigoshop will look into what you have pointed out and update the next version with the bug fix.
Hello!
There is no difference between “if(): endif;” and “if(){}” – just the syntax -IDEs works better with parentheses as they are able to highlight matching ones and even show “if()” statement to show you what’s there.
I will try to figure out what is different between 1.8.1 and 1.9.3.1 in the tax class, but honestly it is working for me in the current version – moreover it is really improved in terms of performance. I have even tried setting this up on 1.8.x series and upgrade to 1.9.x – everything worked like a charm without problems.
The only way to debug this (that comes to my mind) is to search for the problem on your instance – if you could give FTP and admin access to your site on [email protected] I will be looking into this today or tommorow.
FYI. I actually added the 1.8.6 file instead of the 1.8.1.
Unsure why, but now it does work on my install.@megawebmaster my ftp and admin has been sent in multiple times now for weddingprepgals.com.
The issue I had with 1.9.3.1 was when I used an international address, it errored.
My set up – California only tax. If shipping to the US, no problem. But if you attempted Australia or Canada, it would showbup with errors and not allow customers to place order. Now I set the site up with the old file and is working@megawebmaster, email sent, thanks
The topic ‘1.9.3.1 Tax Bug’ is closed to new replies.
