2.2.5 Broke Between Post Insertion

Resolved btreece84
(@btreece84)

8 years, 7 months ago

Updated to 2.2.5 last night and went to my site today to find my between-post ads on the index and archives were not there. Checked source, no code being added by plugin. Checked console, no errors logged.

From another recent support request (issue with WooCommerce), I downloaded a copy of 2.2.3 and rolled it back, all is working perfectly again.

No clue how to help you test this, just know it costs me money to try, and it’s a production site, so testing by disabling plugins one by one isn’t feasible. But 2.2.5 broke something. Theme uses infinite load (after a Load More button is pressed). It has never worked with insertions after the initial set of posts (Load More is missing all ads, despite insertion settings saying there should be one). But again, theme hasn’t been an issue for like a year now.

No other updates since 2.2.4 was released (couple of days), and 2.2.4 worked fine. Just can’t find a copy to download and don’t know which file is causing the issue.

I run a stable site. If it’s a conflict, I can’t see how, but since it’s a production site, I can’t test it. Old site, it crashes any install of Xammp and the like if I try to set up a local dev install for it. Would help with testing if I could.

For now, just know 2.2.5 breaks things. I need a copy of 2.2.4 to install and will continue updating the plugin and rolling back to 2.2.4 until it’s fixed.

Thanks.

Viewing 9 replies - 1 through 9 (of 9 total)

Plugin Author Spacetime
(@spacetime)

8 years, 7 months ago
Version 2.2.4
https://downloads.wp.xz.cn/plugin/ad-inserter.2.2.4.zip

Version 2.2.3
https://downloads.wp.xz.cn/plugin/ad-inserter.2.2.3.zip

Without any data it is hard to figure out what is causing the problem.

You can use debugging function Log processing to find out why some code block was not inserted:
https://adinserter.pro/documentation#debugging
- This reply was modified 8 years, 7 months ago by Spacetime.
Thread Starter btreece84
(@btreece84)

8 years, 7 months ago

Thank you, @spacetime. I will look into the debugger as soon as I can (need off-peak traffic because ads will stop).

Plugin Author Spacetime
(@spacetime)

8 years, 7 months ago

Are you sure version 2.2.4 works fine?
Thread Starter btreece84
(@btreece84)

8 years, 7 months ago
Glad you asked. No, it does not work in 2.2.4, only =<2.2.3.

Logger didn’t show much detail, just that the server is fully capable, clearly. And shows failed checks on the two ads in question. Both are set with filters. One is set after the 4th post in the loop, the other after the 8th post. Fails both checks in 2.2.4 and later.

Here’s what I’m seeing with regard to those specific blocks:
```
BLOCK  3 FAILED CHECK: FILTER 4,14,24
BLOCK  4 FAILED CHECK: FILTER 8,18,28
```
Each of those appears in the summary 29 times. Also get this in more detail, 29 times:
```
  18  BETWEEN POSTS HOOK START
   0  BLOCK 3 FAILED CHECK: FILTER 4,14,24
   0  BLOCK 4 FAILED CHECK: FILTER 8,18,28
   0  BETWEEN POSTS HOOK END
```
Not sure what else to look for. The page has 10 posts loaded, same as always, and 2.2.3 has no problem counting them. I can post the full log if you wish, just wasn’t sure how much you needed and how much info I should post publicly.

Also using a phone-only PHP insertion and a sidebar widget ad, both of those work perfectly in all versions.

Thanks.
- This reply was modified 8 years, 7 months ago by btreece84.
Thread Starter btreece84
(@btreece84)

8 years, 7 months ago
One thing I’m noting in the debug output is it shows the correct version installed right now at the top, 2.2.3. But a few lines down, for the Settings value, shows 2.2.5.
```
Ad Inserter              2.2.3

INSTALLED:               2017-08-31 21:29:40 (0000-01-15 19:30:39, 45 days)
GENERATED (WP time):     2017-10-16 17:00:30
GENERATED (Server time): 2017-10-16 22:00:30
PLUGIN CODE PROCESSING:  54.94 ms
USER   CODE PROCESSING:  0.00 ms
TOTAL PROCESSING TIME:   54.94 ms
SETTINGS:                2.2.5
SETTINGS TIMESTAMP:      2017-10-16 13:16:33
MULTISITE:               NO
USER:                    LOGGED-IN ADMINISTRATOR
```
It’s not preventing everything from working correctly with 2.2.3, but it also showed the same settings value with 2.2.4 when checked for my last reply. If that helps.
Plugin Author Spacetime
(@spacetime)

8 years, 7 months ago

Settings version shows with which version they were created.
Normally there should be no problem using older version of the plugin.

The debugging data helped me to figure out what might be causing the problem.
It seems that the problem occurs when you are using filter counter set to Posts.

If you set it to Auto it should work normally.
Can you please check?
Thread Starter btreece84
(@btreece84)

8 years, 7 months ago
I can confirm that. Changing those blocks filter from Posts to Auto allows those ads to display normally.

However, this:
```
BLOCK  3 FAILED CHECK: FILTER 4,14,24
BLOCK  4 FAILED CHECK: FILTER 8,18,28
```
Still appears in debug, 26 times, not 29. Entries 27-29 are still there and say BLOCK 3 INSERTED, for example. Index only has 10 posts loaded, so only the first insertion point is used, but category archives are 20 long and the first 2 points are used correctly with 2.2.5 and filter set to Auto.

The third point has never worked for me. Posts in the loop loaded after a “Load More” AJAX request do not get ads inserted. That’s not new with 2.2.5 and more likely a theme issue. That’s fine.

Aside from that, switching to Auto seems to have everything working as I expect.
Plugin Author Spacetime
(@spacetime)

8 years, 7 months ago

Each page load (including Ajax requests) starts counting from 1.
The easiest solution is to use insertions that are valid for all pages.

There are many possible reasons why ads are not inserted in Ajax requests:
Usually the page is not presented as WP ajax request or its page type is not post.

To check this try to enable all page types for ajax requests.

Thread Starter btreece84
(@btreece84)

8 years, 7 months ago

Thanks, Igor. Updated the filter to 4,4 and included pages, but no go. Not the end of the world though. Bigger deal is the Posts vs Auto issue, which is worked out for now.