If I’ve got it right, the actual upgrade (if going from 2.5 to 2.5.1) did very little to the database (regenerated the secret password)
Since 2.5 did have the comment_approved key in the comments table and type_status_date key for the posts table, it’s almost like it’s trying to upgrade you from a version PRIOR to 2.5.
Might want to look at your database backup and see if it compares, structure/index wise, to Database Description.
If you do restore your database, you might check/repair your tables before trying the upgrade again.
Of course, you may want to backup your current database just in case.
Thread Starter
davemc
(@davemc)
Thanks, I rolled back the upgrade just to be on the safe side.
My database seems to be 2.5, I just ran the 2.5 upgrade.php again to check.
I’ll do a check/repair before trying the upgrade again.
Dave
i’m seeing the error here, too.
i’m running 2.5 under svn w/o problems. if i run upgrade.php i see the normal notice that the db is up to date.
when i update to 2.5.1 via svn, then run upgrade.php, i see the same error DaveMc posted above:
WordPress database error Duplicate key name ‘comment_approved’ for query ALTER TABLE comments ADD KEY comment_approved (comment_approved) made by dbDelta WordPress database error Duplicate key name ‘type_status_date’ for query ALTER TABLE posts ADD KEY type_status_date (post_type,post_status,post_date,ID) made by dbDelta
Upgrade Complete
Your WordPress database has been successfully upgraded!
i rolled back to 2.5, checked and repaired all db tables, retried the upgrade, and see the same results.
i can see the keys mentioned in the error messages both before and after the attempted 2.5.1 upgrade.
hmm…
the only other reference to this error i’ve been able to find is here:
http://comox.textdrive.com/pipermail/wp-testers/2008-March/007606.html
the fact that this reporter is describing a “2.5 RC2 to 2.5 RC3” upgrade makes me think, like MichaelH mentioned above, that somehow the current version is being reported incorrectly before the upgrade.
looking at the upgrade script, it checks the db_version at line 26. looking at the options table, my db_version has a value of 7558, while the 2.5 tag in subversion is at revision 7567…
so the upgrade script is likely trying to upgrade from a pre-2.5 version, when in reality the db is already at 2.5. meaning, i think i can ignore this error… can anyone give me a sanity check here? specifically, how to be 100% sure (via phpmyadmin or CLI compared to the Database Description MichaelH linked above), that the db schema is as it should be.
looking at the comments table, i see:
Keyname Type Cardinality Action Field
comment_approved INDEX 1 Edit Drop comment_approved 1
looking at the posts table, i see:
Keyname Type Cardinality Action Field
PRIMARY PRIMARY 59 Edit Drop ID
type_status_date INDEX 59 Edit Drop post_type
post_status 1
post_date
ID
looking at the upgrade script, it checks the db_version at line 26. looking at the options table, my db_version has a value of 7558, while the 2.5 tag in subversion is at revision 7567…
That is indeed your problem. And yes, the error is very likely safely ignorable.
The version after the upgrade to 2.5.1 should be 7796.
thanks, Otto42.
out of curiosity, i changed the value of the db_version to 7567, and then 7568 before running the upgrade again. i still saw the error both times, but i’m willing to assume this is safe to ignore at this point. (don’t know the details of how the upgrade script checks the version…)
That’s all located in wp-admin/includes/upgrade.php.
I’m not sure why you’d get that particular error though. The code to add the comments_approved key is way old, back in the upgrade_101 function. And that only runs when db_version < 2541. And I can’t see *any* way for it to try to add type_status_date as a key, that’s in the schema, not as an upgrade anywhere.
Check and make sure you don’t have a second db_version in the options table somewhere. Also disable plugins before upgrading.
hmm, i’m poking through wp-admin/includes/upgrade.php . yeah, that’s odd that we would see these particular errors… the only instance of ‘type_status_date’ turned up by grep is in wp-admin/includes/schema.php .
i definitely don’t have a second row in the options table with option_name=’db_version’… (and the value of that row was updated to 7796 after the 2.5.1 upgrade, as expected.)
at this point, i’m willing to let it go unless anyone sees any red flags in the index descriptions i posted above. (DaveMc, if you chime back in here, i’d be curious how your details compare.)
btw, one thing i noticed in working through this is that my copy of wp-config.php was out of date. specifically, the following constants were not defined in that file: ‘SECRET_KEY’, ‘DB_CHARSET’, ‘DB_COLLATE’. i guess i’d gotten slack in manually watching that file for changes when upgrading from svn.
the missing SECRET_KEY value in particular seems that it could have been problematic since (i believe) it was added in 2.5 and due to the call to the upgrade_251 function in wp-admin/includes/upgrade.php:
update_option('secret', wp_generate_password(64));
i believe in my testing i tried to add those values to wp-config.php before running the upgrade, but by now i’m not sure…
SECRET_KEY was new to 2.5, and it’s not a problem if it’s missing. It’s more secure if you have one though. Read this thread:
http://ww.wp.xz.cn/support/topic/170987
I had the same error.
I found out, that there was a comment marked as “spam” in the comments’ table instead of “0” or “1”.
I deleted the row and the update ran seamlessly.
Maybe could doublecheck this and fix this.
Thanx.
hmm, the blog in question has been working fine, but i’m seeing this exact same error after upgrading from 2.5.1 to 2.6 using svn. very strange… anyone else?
843324
I have the same problem, upgrading from a 2.5 to 2.6, but the blog now stop working correctly. All the permalink does not work anymore.
Moreover I restored the old site, I restored the database, and I restore all the old files in the folder after I deleted the new ones…..but now each page I request returns me a blank page.
any clues?
alk.
843324
Ok I resolved, it turns out that permalink does not work for another reason, so I upgraded to 2.6, ignore that error and everything seems to work fine.
alk.
fwiw, i’m still seeing this error on upgrading from 2.6 to 2.6.1. this time i realized i cannot duplicate the error on my local dev machine — something about my hosting environment…
steps taken:
* clean checkout of WP 2.6.1 from Subversion
* run upgrade.php
dev environment (no errors):
* Ubuntu Gutsy
* Apache 2.2.4
* PHP 5.2.3
* MySQL 5.0.45
live environment (still seeing error detailed above):
* FreeBSD 6.2-RELEASE-p1
* Apache 2.2.9
* PHP 5.2.4
* MySQL 5.0.41
