A few things

Hi Guys,

A few months ago I asked for a capabilty setting, so other managers (not admins) can use the plugin, i see multiple people asking for it and this is not so difficult to include :). I hope this will be included in a future update so I don’t have to modify the plugin with each update.

I’m using the latest version and i’m unable to save the SMTP. When i save the settings, i get a message they are saved, but all fields return empty. And when i go to the send mail page, there’s a message saying i have to set the SMTP…

The plugins uses DataTables jQuery plugin, this generates 2 404’s:
domain.com/wp-content/plugins/wp-email-users/css/images/sort_asc.png 404 (Not Found)
domain.com/wp-content/plugins/wp-email-users/css/images/sort_both.png 404 (Not Found)

IMHO setting an enter after EACH line of code, does not improve readability, i recommend not doing that. Having 2611 lines of code in your base plugin file is also not recommended.

Last but certainly not least, PLEASE load ALL CSS & JS conditionally!!
Now this plugin loads everything on every admin page, this is certainly not the way to go!
Please load js and css like this:

add_action( ‘init’, ‘load_pages’ );
function load_pages() {
$main_page = add_menu_page(….);
$settings_page = add_submenu_page(….);

// Load the CSS/JS conditionally
add_action( ‘load-‘ . $main_page, ‘enqueue_main_page_files’ );
add_action( ‘load-‘ . $settings_page, ‘enqueue_settings_files’ );
}
function enqueue_main_page_files() {
….
}
function enqueue_settings_files() {
….
}

Best regards,

Bjorn

• This topic was modified 8 years, 11 months ago by bjornwebdesign. Reason: added the 404´s
• This topic was modified 8 years, 11 months ago by bjornwebdesign. Reason: load js-css conditionally
• This topic was modified 8 years, 11 months ago by bjornwebdesign.