action=”” in process_form_shortcode.php makes HTML non valid

  • Resolved joachimschlosser

    (@joachimschlosser)


    8 years, 11 months ago

    action="" in line 398 of process_form_shortcode.php makes HTML non valid.
    Removing the property altogether leaves the functionality intact and fixed that HTML violation.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor yikesitskevin

    (@yikesitskevin)

    8 years, 11 months ago

    Hi @joachimschlosser,

    You’re 100% correct. I’ve removed this. I’m planning on pushing a small update at some point today and I will include this fix. Thanks a lot for letting us know! 🙂

    Kevin.

    Thread Starter joachimschlosser

    (@joachimschlosser)

    8 years, 11 months ago

    Thanks, Kevin, great. There is also a ton of other violations around nesting of labels and input fields, but I have not yet looked into it deeply to suggest anything.

    Plugin Contributor yikesitskevin

    (@yikesitskevin)

    8 years, 11 months ago

    Hi Joachim,

    The process_form_shortcode file is huge and handles a lot of different options (so a lot of conditionals). It also mixes HTML and PHP, which can cause a lot of unnecessary output and makes it more difficult to read (especially when combined with conditionals). I am not surprised that there are violations and I’d love to clean up this file more.

    We have a ticket clean up this file so any advice/suggestions you have will be written down and appreciated!

    Plugin Contributor Tracy Levesque

    (@liljimmi)

    🏳️‍🌈 YIKES, Inc. Co-Owner

    8 years, 11 months ago

    Hello.

    Here is the ticket if you want to help out: https://github.com/yikesinc/yikes-inc-easy-mailchimp-extender/issues/640

    Thank you!
    -Tracy

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘action=”” in process_form_shortcode.php makes HTML non valid’ is closed to new replies.