Adminimize rewrites http url to https for all scripts/styles on IIS

  • Resolved Mathijs

    (@mathijs-huis)


    10 years, 4 months ago

    Hi,

    After upgrading to the latest version of Adminimize (1.9.0) some sites failed to load css / js. This was due to the fact that Adminimize rewrites http url’s to https (for all the registered scripts/styles?)

    After comparing both versions I traced it down to inc-setup/helping_hands.php where a check for https is implemented:

    if ( ! empty( $_SERVER[ 'HTTPS' ] ) ) {

    This is not working on Windows hosts with IIS where the value will be “off” when https is *not* enabled.

    Is it possible to include a check for this situation?

    Mathijs.

    https://ww.wp.xz.cn/plugins/adminimize/

Viewing 15 replies - 1 through 15 (of 20 total)
1 2
  • webbro

    (@webbro)

    10 years, 4 months ago

    Same problem here,

    changed
    if ( ! empty( $_SERVER[ 'HTTPS' ] ) ) {
    to
    if ( empty( $_SERVER[ 'HTTPS' ] ) ) {
    which works for a temporary fix for me

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    Thanks for the hint!

    Please can you test this current master – Download: https://github.com/bueltge/Adminimize/archive/master.zip

    If it works not, can you print the $_SERVEr for me, in inc-setup/helping_hands.php, Line 65 add the follow line and send me the output from the fron end.
    var_dump($_SERVER[ 'HTTPS' ]);

    Thanks!

    Thread Starter Mathijs

    (@mathijs-huis)

    10 years, 4 months ago

    Hi Frank,

    Thanks for your quick response.

    This does not work, the IIS server passes ‘off’ as value when it’s not a https request. The var_dump returns:
    string(3) “off”

    (When it’s a https request, the value is: “on”)

    Mathijs.

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    Hi Mathijs.

    Thanks for your fast reply. I have update the repository again and checks now also for the value off. it would be fine, if you can retest again, same Download.

    Thanks!

    Jason Judge

    (@judgej)

    10 years, 4 months ago

    Just had this happen on a Linux multi-site too – every single site stopped working because of the rewritten URLs (it was forcing the scripts and JS files to a self-signed certificate, which was causing the browser to reject them).

    Uninstalled, and now multi-site is fine.

    bambino

    (@babybitch1976)

    10 years, 4 months ago

    Same issue here. Deactivated until a fix is available.

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    Hi Jason, hey John.
    Do you have test the version from github, linked in this thread? Works this correctly in your setup?

    Thanks for time and feedback.

    Jason Judge

    (@judgej)

    10 years, 4 months ago

    I just needed to get the sites working before leaving for the weekend, so just removed the plugin. I’ll look at a more long-term solution next week.

    Georgeeee

    (@georgeeee)

    10 years, 4 months ago

    i have the same problem

    at some sites rewrites css url to https

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    Also my hint and please, can you test the linked download?
    https://github.com/bueltge/Adminimize/archive/master.zip

    This version have a fix for this topic, but I can’t check this in my development environments.

    SoreX

    (@sorex)

    10 years, 4 months ago

    Hi Frank, I have the same problem of John and Jason, I’ve tried your master and now it works fine!

    I’ve tried it on IIS 8.5 on Windows Server 2012 R2.

    Thanks!

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    Thanks a lot SoreX!

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    New small fix release is public. I hope this fix the ssl topic.

    SoreX

    (@sorex)

    10 years, 4 months ago

    Hi Frank, the SSL problem seems now fixed on IIS 8.5 with WP 4.4.1.

    Now there are only one graphic problem on ‘permissions table’;
    You can see it here: image

    Plugin Contributor Frank Bueltge

    (@bueltge)

    10 years, 4 months ago

    In which browser do you have this problem?
    On my clients, Linux and Win, Chrome and FF works fine.

Viewing 15 replies - 1 through 15 (of 20 total)
1 2

The topic ‘Adminimize rewrites http url to https for all scripts/styles on IIS’ is closed to new replies.