AMP issue

  • Davide Prevosto

    (@daweb)


    7 years, 3 months ago

    Hi there,

    is your plugin still supported?

    We are notice an issue with AMP pages, it seems script is embed twice in our pages, as I wrote to the issues board of Accelerated Mobile Pages plugin:

    https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/2889

    <script custom-element="amp-brid-player" src="https://cdn.ampproject.org/v0/amp-brid-player-latest.js" async></script>

    AND

    <script type="text/javascript" src="https://cdn.ampproject.org/v0/amp-brid-player-0.1.js" async custom-element="amp-brid-player"></script>

    Do you have any suggest?

    Thank you

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Sovica

    (@sovica)

    7 years, 3 months ago

    Hi Davide,

    What Brid plugin version are you using and also what AMP plugin are you using?
    Do you also perhaps have an example page where we can see this problem?

    Thread Starter Davide Prevosto

    (@daweb)

    7 years, 3 months ago

    Hello @sovica

    we are using your last version: 2.9.1 and ampforwp.com plugin, to manage AMP (it uses official AMP plugin out of the box) => https://it.ww.wp.xz.cn/plugins/accelerated-mobile-pages/

    Unfortunately I can’t publish here the example page (but I will do in a private thread, of course).

    I didn’t find a hook to override your

    public static function amp_brid_script() {} function,

    in BridShortcode.php, so I did comment your:

    <script type="text/javascript" src="https://cdn.ampproject.org/v0/amp-brid-player-0.1.js" async custom-element="amp-brid-player"></script>

    inclusion, and I did request an AMP validation on Google Search Console. Mine is a workaround, I would like to fix with you the issue.

    Thanks

    Plugin Author Sovica

    (@sovica)

    7 years, 3 months ago

    Davide,

    It looks like that the ampforwp plugin added inherit support for our player in the AMP ecosystem so it references the required JS file and so do we so there is a double-reference currently.

    We’ll be pushing a change to our plugin so that we remove our reference and let the ampforwp plugin do this instead of us as it seems to be the fastest way to fix this inconsistency.

    You can expect a new plugin version of our plugin today regarding this.

    Thanks for bringing this to our attention.

    Thread Starter Davide Prevosto

    (@daweb)

    7 years, 3 months ago

    This sounds so good. Thanks for support and fast reply.

    Have a nice day

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘AMP issue’ is closed to new replies.