Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author Chris Reynolds

    (@jazzs3quence)

    I was able to reproduce this. I created a ticket: https://github.com/jazzsequence/book-review-library/issues/9

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Scratch that, the site I was testing on had custom templates for the book review lists which is why I was able to reproduce it. When testing with another theme, I was unable to reproduce the issue.

    Thread Starter alexandrebarault

    (@alexandrebarault)

    Hi,

    I push the website on the web on the http://wordpressprint.azurewebsites.net And I can see the issue as in local.
    I use the simple template twentytwelve.

    I can give you access to the admin page.
    So I don’t know how I can contact in private to share user/password.

    Regards,
    Alexandre

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Have you confirmed that all of those books actually have authors?

    If so, no access needed, but if you could create an export file for the book reviews (from Tools -> Export) and post it on pastebin or someplace off the forums, I can check it out on my local installation.

    Thread Starter alexandrebarault

    (@alexandrebarault)

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Great, got it. You can delete that file from your server now. I’m going out of town for about a week, so I probably won’t have time to take a look until I get back.

    Thread Starter alexandrebarault

    (@alexandrebarault)

    Chris, Thanks to share your agenda.
    I search on my side during this week.

    Regards,
    Alex

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Alex —

    I’ve tracked down this issue. There’s a check in there that’s failing where the title that’s being passed to the filter is checked against the post title. I’m trying to figure out why that was originally put in and apply a fix. There should be an update forthcoming.

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Okay, found it. Here’s what’s happening:

    WordPress applies some filters to the title before the title gets passed to the book review plugin. The book review plugin applies some filters of its own to the title but, to make sure that it hasn’t applied those filters to the post title already, it checks to make sure the title matches the post title that was entered in the database. Here’s the problem:

    https://cloudup.com/ix7jMoyRvgf
    https://cloudup.com/irbqWbJi4vw

    In both these examples, the title has been modified slightly. In the first case the – has been changed to an — (emdash). In the second case the ‘ is being changed to a ’ (curly quote).

    In both cases, the title doesn’t match, so the filter thinks it’s already been run and stops. Other book titles work fine because they don’t have those characters in the title (like the Zombi book). This plugin was (obviously) written by an American who doesn’t need to worry as much about having apostrophes in titles, so this never came up for me when I was testing! I will have a fix for it today.

    Plugin Author Chris Reynolds

    (@jazzs3quence)

    Issue resolved in 1.4.9 update.

    Thread Starter alexandrebarault

    (@alexandrebarault)

    Hi Chris,

    Thank you to share the details and to fix it, I understand the points about – and ‘.
    So it’s a good point.

    I notice :
    You modify the file book-review-library/trunk/views/public.php
    by removing the condition $title == $post->post_title
    and I see the modification about the cover.

    Have a good day.

    Regards,
    Alexandre

    TheGamingWizard

    (@thegamingwizard)

Viewing 12 replies - 1 through 12 (of 12 total)

The topic ‘Author don't display’ is closed to new replies.