Background image bug report

  • Resolved JboyJW

    (@jboyjw)


    4 years, 11 months ago

    Updated to the latest version (2.2.32) and the background images that I had on my accordion buttons disappeared. They still show up in the admin, but not on the front end display. The background url() in the CSS is blank.

    Checked the code and found that you’ve introduced the esc_url_raw() function to escape the background image URLs. Which is fine, but on line 265 of templates/accordion/accordion-hook.php, you use esc_url_raw() around $header_bg_img which contains url() in it, so of course it fails and removes the whole URL. The esc_url_raw() needs to be moved to wrap the $background_img on line 260 instead so that it only escapes the actual URL.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter JboyJW

    (@jboyjw)

    4 years, 8 months ago

    Just updated to 2.2.34. Still not fixed.

    Thread Starter JboyJW

    (@jboyjw)

    4 years, 5 months ago

    Still not fixed in 2.2.35

    Plugin Support hasanrang05

    (@hasanrang05)

    4 years, 4 months ago

    Sorry for late reply, i just fixed and update plugin.

    Please let me know the result.

    Thread Starter JboyJW

    (@jboyjw)

    4 years, 4 months ago

    Thanks for the update! I downloaded 2.2.36 and yes, the background image code has been fixed properly, but it’s still not working because several other places in that file are incorrect:

    Still in templates/accordion/accordion-hook.php, the space has been removed after all references to #accordions-<?php echo esc_attr($post_id); ?>

    Lines 165, 172, 179, 185, 190, 195, 205, 214, and 233 all need a space after #accordions-<?php echo esc_attr($post_id); ?> to make the CSS work.

    Plugin Support hasanrang05

    (@hasanrang05)

    4 years, 4 months ago

    I understand the issue, this was VS code formater issue.

    Please update and let me know the result 2.2.37

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Background image bug report’ is closed to new replies.