[BUG] Advanced Link Sub Fields

Hello,

Thanks for the feedback!

I just tested it, and it works fine on my end. Here is the video of my test with a switch & repeater sub field.

Can you please share the code you’re using to register these sub fields (or at least part of them if there’s too many)? So I can try to reproduce the issue on my side.

Here is the code I used, if you’re interested:

add_filter('acfe/fields/advanced_link/sub_fields/name=my_advanced_link', 'my_acf_advanced_link_sub_fields', 10, 3);
function my_acf_advanced_link_sub_fields($sub_fields, $field, $value){
    
    $sub_fields[] = array(
        'name'      => 'my_field',
        'key'       => 'my_field',
        'label'     => 'My field',
        'type'      => 'true_false',
        'ui'        => true
    );
    
    $sub_fields[] = array(
        'key' => 'repeater',
        'label' => 'Repeater',
        'name' => 'repeater',
        'aria-label' => '',
        'type' => 'repeater',
        'instructions' => '',
        'required' => 0,
        'conditional_logic' => 0,
        'wrapper' => array(
            'width' => '',
            'class' => '',
            'id' => '',
        ),
        'layout' => 'row',
        'pagination' => 0,
        'min' => 0,
        'max' => 0,
        'collapsed' => '',
        'button_label' => 'Add Row',
        'rows_per_page' => 20,
        'sub_fields' => array(
            array(
                'key' => 'sub_field',
                'label' => 'Sub Field',
                'name' => 'sub_field',
                'aria-label' => '',
                'type' => 'text',
                'instructions' => '',
                'required' => 0,
                'conditional_logic' => 0,
                'wrapper' => array(
                    'width' => '',
                    'class' => '',
                    'id' => '',
                ),
                'default_value' => '',
                'maxlength' => '',
                'placeholder' => '',
                'prepend' => '',
                'append' => '',
                'parent_repeater' => 'field_63e57b78406a0',
            ),
        ),
    );
    
    return $sub_fields;
    
}

Thanks in advance!

Regards.

Hello,

Thanks for the details!

I can confirm that it also works on Gutenberg and after a refresh.

However, I see that you’re missing key arguments in your sub fields declaration, this is what is causing the issue.

Adding a key in all sub fields will fix the issue. Usage example:

public static function add_advanced_link_fields( $sub_fields, $field, $value ) {
    $sub_fields = array_merge(
        $sub_fields,
        array(
            array(
                'name'  => 'tn_element',
                'key'   => 'tn_element',
                'label' => 'Turnstile Element Name',
                'type'  => 'text',
            ),
            array(
                'name'  => 'aria_label',
                'key'   => 'aria_label',
                'label' => 'Aria Label',
                'type'  => 'text',
            ),
        )
    );
    
    return $sub_fields;
}

I think it’s an oversight from the rework of the Advanced Link field in 0.8.9. Previously, a subfield with a missing key would have its key generated using its name.

However, the rework considerably enhanced the field logic, to make it compatible with more complex subfields such as Repeater/Flexible Content, which wasn’t possible with the previous logic. The old “generate key when missing” code was part of the logic which made Repeater/Flexible Content incompatible back then.

I’ll add a safeguard in the next update in order to handle the scenario where subfields keys are missing, just in case.

However, note that it is considered good practice to provide a field key whenever you’re declaring a field (in ACF or ACFE). It’s always better to provide it, so you can have full control on it.

Hope it helps!

Have a nice day!

Regards.

Hello,

I’m glad to hear it now works as expected!

Have a nice day!

Regards.