Bug in code. Notice always showed

I found a bug in latest plugin version. You are adding the following action on each request:

add_action( 'admin_notices', 'Ga_Admin::admin_notice_googleanalytics' );

And admin_notice_googleanalytics have if statement which equals to true on every other plugin page and even on default WordPress settings pages.

if ( ! empty( $_GET['settings-updated'] ) ) {
echo Ga_Helper::ga_wp_notice( _( 'Settings saved' ), self::NOTICE_SUCCESS );
}

As result all users see notice twice. And your notice have broken markup (css classes) (seems height not defined).

• This topic was modified 9 years, 4 months ago by Nicolas Korobochkin.