Bug with styles found

  • Resolved pobrehablador

    (@pobrehablador)


    6 days, 7 hours ago

    This is totally wrong (in quotes-llama/class-quotesllama.php):

    wp_enqueue_style( 'dashicons-style', get_stylesheet_uri(), array( 'dashicons' ), $this->plugin_version() );

    the right method is:

    wp_enqueue_style( 'dashicons' );

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author oooorgle

    (@oooorgle)

    6 days ago

    Are the dash-icons set not working?

    https://developer.ww.wp.xz.cn/reference/functions/wp_enqueue_style/

    Thread Starter pobrehablador

    (@pobrehablador)

    5 days, 23 hours ago

    Of course it is not working. What the current line of code in this plugin does is enqueue the active theme’s stylesheet with a wrong handler, not WordPress’s Dashicons stylesheet. That is why I proposed the correct solution of using: wp_enqueue_style( 'dashicons' ); which is the appropriate approach if the intention is to make this icon set available on the frontend. In any case, it would be useful or interesting to have an option in the plugin settings where this is optional. If the user does not want to display those icons in the quotes, there is no need to load the Dashicons stylesheet on the frontend, and the page load can be reduced.

    Plugin Author oooorgle

    (@oooorgle)

    5 days, 22 hours ago

    Yes I see! I will get that fixed in the next update. I will look at adding that option as well… have a few things with this plugin where it need to be optimized better. Really struggling to find the best solution between using a large dataset of quotes vs. excessive ajax calls, for example. Please do let me know if you happen to notice anything else.

    Thanks for the heads up!

    Plugin Author oooorgle

    (@oooorgle)

    4 days, 20 hours ago

    Hi pobrehablador,

    I have fixed the enqueue for the dash-icons. Thanks again!

        if ( $this->check_option( 'show_icons' ) ) {
        wp_enqueue_style( 'dashicons' );
    }
Viewing 4 replies - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.

Tags