Thanks for the feedback.
Unfortunately if we fix it there, it won’t work where it really shines, which is on your blog posts and articles page.
What I recommend is doing a conditional in functions.php.
Something like:
if ( is_front_page() ) {
add_filter( 'has_show_facebook', '__return_false' );
add_filter( 'has_show_twitter', '__return_false' );
}
Thanks for the report on the typo. I’ll try to address that this weekend.
Regarding page IDs, I think most users will not want to manually punch in IDs from my experience.
A better approach I think is add a small meta box to the page and provide a checkbox that will disable the plugin if checked.
What do you think?
Can see how that conditional statement would work.
I want to provide a better suggestion instead of the “actual URL” mentioned earlier. It can continue pulling the URL as it does, but it should first check for twitter card and opengraph markup. That would solve the problem and be more of a best practice.
Some plugins like GetSocial block themselves from pages that way you suggested. A global setting to allow/disallow on all pages/posts to speed setup would be good and then have the individual settings you speak of that override global.
I have tried:
if ( is_front_page() {
add_filter( 'has_show_facebook', '__return_false' );
add_filter( 'has_show_twitter', '__return_false' );
};
and as a basic function in functions.php but no change.
What are your Settings-> Reading settings in the admin area? That may provide a clue.
Well, posting that screenshot was insanely helpful. It basically said, “I”, as in me, Ronald, screwed up somewhere, and yes, indeed, I did 😀
I just released version 1.2.0 which fixes the typo you mentioned above and fixes a bug I wish I had caught way earlier, which is the loading of my filters.
1. For disabling on the front page, here’s what you can use now: https://github.com/ronalfy/highlight-and-share#disable-sharing-on-a-static-front-page
2. For changing the content URL, you may now use: https://github.com/ronalfy/highlight-and-share#modify-the-content-url
Sorry about that and hope the above helps.
Very awesome! Support threads like this just help the plugin get more useful.
Not an obligation by any means, but please consider a rating/review of the plugin.
Take care!
