I have the same problem after upgrading to 5.3. The Client ID and Secret simply do not save to the database anymore. Which is really annoying as I show lots of Strava activities and maps, so people can download my routes as gpx.
Onerunner.nl
Thanks for the update, I haven’t had a chance to test against 5.3 yet, but at work we’ve had some issues on a couple projects and had to downgrade. I recommend using https://ww.wp.xz.cn/plugins/wp-downgrade/ to get back to 5.2.4
I’m hoping to have some time in the next two weeks to see what exactly is going on and publish a release update.
Thread Starter
jw2019
(@jw2019)
Ah lovely (well not lovely) that you confirmded the problem is with 5.3 of wp. Hopefully there will be a fix shortly. The other option is of course moving back to the previosu version. I do have a backup.
On a different note, what a lovely green shirt 😉
@jrfoell
Unfortunately downgrading is not an option, I am on a hosted version that automatically updates 🙁 So I really do appreciate you looking into it.
Apparently the keys are all in the database. But somehow the GMaps key is shown, but the one for Strava isn’t. Also the token for Strava does not update or change and adding a new token manually to the database does not solve the problem.
@jw2019
Thanks about the green shirt. I prefer to run the trails, but Rotterdam is an exception, mainly due to the friends of the Rotterdam Marathon Deelnemers. Do you have a green shirt as well?
Thread Starter
jw2019
(@jw2019)
@rmdejong I’m in the RDM group but since I’m living in that other city, I’m a bit hesitant putting one on 😉
Fingers crossed on a fix though. It’s a very nice feature having the strava routes on the site.
@jrfoell
I did manage to use the downgrade to 5.2.4. However, the plugin does not work anymore… it must be something that has changed either at Strava or in the database after the upgrade.
-
This reply was modified 6 years, 6 months ago by
rmdejong.
Same issues as others on WordPress 5.3
I can see the Client ID and Client Secret are saved in the relevant database fields though. So it’s strange they don’t populate on the /options-general.php?page=wp-strava-options page in WP admin area?
I have that same problem. To solve it and make authorization I change in /wp-content/plugins/wp-strava/includes/WPStrava/Settings.php:648
from
return isset( $value[0]['type'] ) && 'updated' === $value[0]['type'];
to
return isset( $value[0]['type'] ) && 'success' === $value[0]['type'];
and in /wp-content/plugins/wp-strava/includes/WPStrava/Auth.php:55-57 remove
if ( $settings->ids_empty( $input['strava_id'] ) ) {
return array();
}
@radio1985 that’s brilliant. That does indeed fix it! Legend.
Thread Starter
jw2019
(@jw2019)
@radio1985 Brilliant indeed! It’s all good again.
Thanks for the sleuthing @radio1985 – I’ll try to get that committed and released this weekend!
Thanks for your patience everyone. I got time to do some testing in WP 5.3 to make sure things are working as expected. Shout out to @radio1985 for helping me jump right in, I was able to start with his changes and make sure things work with WP 5.2 and under _and_ 5.3 and over.
Please upgrade at your convenience. If you have any other issues, please post them in this support forum. If you’re feeling extra grateful this season, please add your rating to help bump this plugin up: https://ww.wp.xz.cn/support/plugin/wp-strava/reviews/#new-post
