Changing “no forums found” message doesn’t work

[justdave]

On the Forum Index Styling tab, #14 at the bottom says to let you change the text shown when no forums are found, with the default being “Oh bother! No forums were found here!”

Changing the text here has no effect on the text shown on the page. I have my bbPress set up so that the forums are only visible when you log in, so I want to change this message to indicate that you need to log in first instead of saying there are no forums.

Been poking at the source code and I can’t for the life of me figure out what’s wrong. Although I see at least one bug, fixing that doesn’t seem to fix the problem.

The bug that I see is that bbPress seems to have changed the string they use for that message, and it’s actually “Oh, bother! No forums were found here.” now. (Changes in punctuation to it).

But changing bsp_change_text4 in bbp-style-pack/includes/functions.php to look for that string instead doesn’t seem to fix it.

bbPress 2.6.3 | bbp-style-pack 4.3.7

[Robin W]

Thanks for spotting that.

I’ve just released version 4.3.8 which allows for both versions

[justdave]

Thanks, but like I said in the message that still didn’t fix it. The text is not replaced on the page. Even with all the other plugins besides bbPress and bbp-style-pack disabled to ensure no conflicts.

[Robin W]

it works fine in my test site – do you have caching software, need a browser refresh etc.

[justdave]

I had WP Super Cache installed, but manually nuking the cache didn’t help, and it’s completely disabled now, and the text still doesn’t update. I can make other style changes and they show up immediately in the browser, so the browser’s not caching it… In fact, I can use curl from the command line to retrieve the page and still see the original text in the HTML. Even tried killing off all the php processes in case it was getting cached in memory on the server.

[Robin W]

hmmm…not sure I can help further seems to be site specific, particularly since you have already done the logic yourself, and disabled plugins.

I can only suggest that you copy the function to your child theme functions file (and rename to prevent duplicate) and see if it will work there, but I can’t see why it should !!

[justdave]

ok, so trying to debug this, I turned on debugging and dropped the following in:

error_log("exmpty_index = " . $bsp_style_settings_f['empty_index'] );

right in front of:

if (!empty ($bsp_style_settings_f['empty_index'] )) add_filter( 'gettext', 'bsp_change_text4', 20, 3 );

And it winds up throwing an warning in the log that bsp_style_settings_f isn’t defined. I see it’s loaded as a global, so I’m guessing that’s defined in some other file, and they’re loading in the wrong order?

I appear to be on PHP 7.2…

[Robin W]

ok, can you add this line in functions.php at line 20 and see if it fixes

global $bsp_style_settings_f ;