Close button focus

  • Resolved JboyJW

    (@jboyjw)


    5 years, 4 months ago

    From what I’ve read, if there is no focusable element in the popup, then the close button will receive focus when the popup opens.

    When a popup auto-opens, the focus remains at the beginning of the page.

    When a popup opens by click, the focus remains on the button that was clicked.

    I have the latest version of Popup Maker, latest version of WordPress, I’ve tried changing themes to another theme, and there are no javacript errors in the console. Am I missing something? I’ve added a Test button to the page to demonstrate.

    Oh, and I just test with a form in popup and that didn’t get focus either…

    The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter JboyJW

    (@jboyjw)

    5 years, 4 months ago

    Just to add to that, I also tried disabling all other plugins, tried using other popup themes, and tried adding a brand new popup, and it still wouldn’t work.

    And just to clarify, I do NOT have the Disable accessibility features option checked off.

    Bel

    (@belimperial)

    5 years, 4 months ago

    Hello @jboyjw

    Thank you for reaching out.

    For the focus feature to work, you may need to add a link or button inside the content of the popup.

    Please see this sample: https://www.loom.com/share/fe998c88925d4e96b36316f1ef207c99

    An HTML tag list and button should be on the source page or div content of the popup. Please note that the close button is part of the popup but it is outside of the popup content Checking your sample page, it doesn’t have a list or button inside it.

    Hope that helps.

    Let us know if you have any questions or if your issue is resolved please take a moment to rate and review the plugin.
    If you still need help please message us directly at https://wppopupmaker.com/support/

    Thread Starter JboyJW

    (@jboyjw)

    5 years, 4 months ago

    Thanks for the explanation, Bel. I would say that this is a bug then. It doesn’t make sense that when I use Popup Maker for an informational modal that a keyboard user has to tab around the page behind until they can find the close button to close it. Sure I can activate the Esc key closing it, but there’s no easy visual way to close it with a keyboard. The close button should absolutely get focus if no other focusable element exists.

    In fact, it does seem to be an issue with the .pum-close trigger. Even if a I add my own close button within the content by adding the pum-close class to the button (which allows it to work as a close button), the focus won’t initially set to it. The focus will only set if I add a button or link that doesn’t have a the pum-close class.

    I’ll go ahead and submit a support request to have this fixed. Thanks.

    Bel

    (@belimperial)

    5 years, 3 months ago

    Hello @jboyjw

    We have an announcement that we have Popup Maker v1.16.0 Beta. This is to address improvement for accessibility forced focus. It can now focus on the main close button if nothing else is available.

    If you are interested in testing the beta version out, you can download the attached zip file (the popup-maker_v1.16.0-beta.1.zip one) here.

    You can upload the beta version as a normal plugin within any WordPress site. While we have tested this version, please note that it is never recommended to test beta versions on live sites. Please test only on staging or dev sites.
    * Feature: Add ‘flush popup cache’ link in admin bar menu.
    * Improvement: Remove ‘Tools -> System Info’ page, use WP Site Health page instead.
    * Improvement: Accessibility forced focus can now focus main close button if nothing else is available.
    * Improvement: Updated admin form styles to match recent WP core changes.
    * Fix: Bug preventing saving “Sitewide” cookie option unchecked.
    * Fix: Removed Action Scheduler library due to edge case issues with no reasonable long-term solutions.

    I hope this helps.

    Let us know if you have any questions or clarification on this matter.

    Thread Starter JboyJW

    (@jboyjw)

    5 years, 3 months ago

    Thanks so much! Works great now. Can’t wait for it to be included in the next release.

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Close button focus’ is closed to new replies.