columns__wrap applying padding incorrectly

  • Resolved lyden

    (@lydenyardley)


    7 years, 2 months ago

    I’ve deleted every value from padding and margin fields on a given ‘Advanced Columns’ block, and the plugin is still overriding:

    #uagb-columns-02fffb90-81a9-4eee-a7c2-a95bdf200568.uagb-columns__wrap {
    padding-top: 20px;
    padding-bottom: 20px;
    padding-left: 20px;
    padding-right: 20px;
}

    Can you fix please?

    The page I need help with: [log in to see the link]

Viewing 12 replies - 1 through 12 (of 12 total)
  • zabavljaev

    (@zabavljaev)

    7 years, 2 months ago

    The plugin overrides if you leave the fields empty, but if you put 0, then padding: 0. If I’m not mistaken.
    I think 20px is the default
    And if the field is empty, then the default value is set.

    Thread Starter lyden

    (@lydenyardley)

    7 years, 2 months ago

    Hi @zabavljaev, unfortunately your response misses the point.

    I don’t want the padding to be 0. I also don’t want it to be 20px. I want it to inherit my custom CSS. As these styles are applied to the ID of the particular section, it becomes problematic.

    Plugin Support Team Brainstorm Force

    (@brainstormteam)

    7 years, 2 months ago

    Hello @lydenyardley,

    This is an issue with default values, We have already added this to our bug list and are looking forward to resolving it at the earliest.

    Your patience is highly appreciated.

    Regards,
    Balachandar Karuparthy

    Thread Starter lyden

    (@lydenyardley)

    7 years, 1 month ago

    Hi team,

    Can you provide an update on this please?

    Plugin Support Team Brainstorm Force

    (@brainstormteam)

    7 years ago

    Hello @lydenyardley,

    It is an issue with Gutenberg as it doesn’t save the empty values. Gutenberg replaces the empty values with the default values. We have already opened a ticket with them. You can view the updates here – https://github.com/WordPress/gutenberg/issues/14629

    Unfortunately, We can’t do anything since it is a Gutenberg issue. We will try to provide them inputs to get this fixed.

    We really appreciate your patience with this issue.

    Regards,
    Balachandar Karuparthy

    Thread Starter lyden

    (@lydenyardley)

    7 years ago

    Thanks – back over to you to respond to the Gutenberg people. They’re awaiting your checks and response.

    Thread Starter lyden

    (@lydenyardley)

    6 years, 10 months ago

    Hello again,

    It looks like you need to follow up with the Gutenberg tegam on this one – they closed your issue as they were awaiting more information.

    Thanks,
    Lyden

    Plugin Support Team Brainstorm Force

    (@brainstormteam)

    6 years, 10 months ago

    Hey,

    I do agree with what they are intending to say here.

    It is intentional that if a value is reset to its default, it would not be assigned in the generated attributes of a block. It is done this way so that, for example, the default could be changed in the future and all existing content which does not have a specific value assigned would automatically begin using this new default.

    I think we should keep it the way it is.

    We might need to come up with a mediator solution to this problem. We would love to hear your views on this.

    Also, my team will brainstorm and try coming up with some solution. We appreciate your patience.

    Regards,
    Vrunda Kansara

    Thread Starter lyden

    (@lydenyardley)

    6 years, 10 months ago

    Hi @brainstormteam,

    It seems to me (unless I’m mistaken), that the gutenberg team and I agree on the way it should work, and that your team is doing something additional to the default behavior…

    The quoted section you included in your last comment is what I’m expecting too! Specifically:

    if a value is reset to its default, it would not be assigned in the generated attributes of a block

    Your plugin DOES assign values to the block… it shouldn’t in order that changes to default values can be inherited by

    all existing content which does not have a specific value assigned

    Does that make sense?

    Your defaults should be applied in your stylesheet, and not to the block attributes unless

    a specific value assigned

    • This reply was modified 6 years, 10 months ago by lyden.
    • This reply was modified 6 years, 10 months ago by lyden.
    Thread Starter lyden

    (@lydenyardley)

    6 years, 5 months ago

    Hi team,

    This issue still exists, even after checking your latest update that mentions swapping IDs for classes.

    Please can you update on this?

    Regards,
    Lyden

    Thread Starter lyden

    (@lydenyardley)

    6 years, 2 months ago

    Hello team,

    Following up for progress on this. It’s been open over a year now and I’ve been very patient. Your plugin is not working according to WordPress standards – see my specific comments and highlights above.

    Thanks,
    Lyden

    Plugin Support Team Brainstorm Force

    (@brainstormteam)

    6 years, 1 month ago

    Hello @lydenyardley

    Like we mentioned earlier, the Gutenberg editor does not store the default values. The block will have a different view in frontend and backend if we removed this functionality.

    If you want to set it to 0, you can set it from the block options. We are helpless here since the Gutenberg framework provides this type of functionality.

    Regards

Viewing 12 replies - 1 through 12 (of 12 total)

The topic ‘columns__wrap applying padding incorrectly’ is closed to new replies.