Compatibility with 2 super important plugins

  • Resolved sami770

    (@sami770)


    6 years, 10 months ago

    First of all – thanks for this AMAZING plugin, I love it.
    I made a few speed tests with google official speed test tool and found out that your plugin improved site speed significantly 🙂

    I have 1 issue and 1 concern.

    The issue: after installing the plugin and created a few settings, the main menu is not foldable on mobile phones, see the following site (from mobile phone) for example: hemprodukter (dot) info

    https://hemprodukter (dot) info/?wpacu_no_load – NO mobile menu problem
    https://hemprodukter (dot) info/?nocache – NO mobile menu problem
    https://hemprodukter (dot) info/ – mobile menu problem

    How can it be fixed?

    The concern: is this plugin is 100% (not 99% but 100%) compatible with WP rocket and elementor (free and pro versions)?
    If it is 100% compatible with them, what is the most recommended way to use it? first install wp rocket, fix all settings there and ONLY AFTER THAT install Asset CleanUp and fix its settings?

    • This topic was modified 6 years, 10 months ago by sami770.
Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter sami770

    (@sami770)

    6 years, 10 months ago

    Update:
    When I turn “JavaScript Files Minification” off – the problem is solved, but the site is not as fast anymore. How do I keep “JavaScript Files Minification” on without breaking the menu on mobile?

    Plugin Author Gabe Livan

    (@gabelivan)

    6 years, 10 months ago

    @sami770 thank you for raising this ticket and for your concerns about compatibility issues! The plugin is compatible with WP Rocket and Elementor 100% if used correctly. What this means is the fact that there are functions of WP Rocket and Asset CleanUp that could interfere with another. For example, if you use “Optimize CSS Delivery” with WP Rocket, which has its purpose and is meant to do one thing, then Minify/Combine CSS in Asset CleanUp will be disabled.

    In terms of compatibility with Elementor, there have been many changes to ensure both plugins work fine. For instance, Asset CleanUp is not triggered while Elementor editor is ON and extra notices about Elementor assets (CSS/JS), as well as the feature ‘Ignore dependency rule and keep the “children” loaded‘ have been added to Asset CleanUp.

    I’ve checked your website and, in the browser’s console, I’m getting the following error: Uncaught ReferenceError: Invalid left-hand side expression in postfix operation

    This is from the way the file /wp-content/plugins/widgetkit-for-elementor/admin/assets/js/core.js was minified, which is a bug that needs to be fixed. So, keep the Minify CSS enabled, go to “Minify CSS & JS Files” and add the file I just mentioned to the following list:
    Do not minify the CSS files matching the patterns below (one per line):

    Note that I will analyze the file and make further tests to make sure that minified versions will not trigger any errors if other users will attempt to minify it. So, my apologies for this inconvenience as it’s an issue I’m taking responsibility for. Please do the changes I mentioned and let me know how it goes! Looking forward to further assist you!

    PS: In this case, Asset CleanUp was not 100% compatible with WidgetKit for Elementor as that JS file was not minified properly. Tests have been made on Elementor and Elementor Pro, but not on WidgetKit for Elementor. I’ll make sure to focus on it!

    • This reply was modified 6 years, 10 months ago by Gabe Livan.
    • This reply was modified 6 years, 10 months ago by Gabe Livan.
    Thread Starter sami770

    (@sami770)

    6 years, 10 months ago

    Thank you very much for taking the time to answer in detail, much appreciated!
    I perfectly understood your explanation, but I did something else that also worked for me 🙂
    I disabled the “widgetkit-for-elementor” plugin, cleaned the cache, activated the “widgetkit-for-elementor” and cleaned the cache again. I did not even have to touch the “minify css” feature or to add anything to it, it is always enabled.
    Now the mobile menu works good again.
    But yes, it will be great if you investigate it and apply the necessary fix in next update.

    Thanks for the info regarding compatibility with elementor (free+pro) and wp rocket, these are 2 crucial plugins for many many wp admins so it’s important that your great plugin will always be compatible with them.

    Please keep the good job!

    Thread Starter sami770

    (@sami770)

    6 years, 10 months ago

    Update: after additional check, I realized that my “trick” did not work, the mobile menu was actually still broken.
    So I applied your instructions and now it works. Thanks!

    Plugin Author Gabe Livan

    (@gabelivan)

    6 years, 10 months ago

    @sami770 Hello, again! Just so you know, a new tag was just released which has a fix for the minification done to core.js. You can update the plugin and quickly test this by removing the file from the exclusion list. The mobile menu should not be broken anymore 😉

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Compatibility with 2 super important plugins’ is closed to new replies.