Confirmation Email Resending Issues

  • getsnoopy

    (@getsnoopy)


    1 week, 2 days ago

    Hello,

    I noticed multiple bugs with the functionality of the resending of confirmation emails:

    1. I was noticing that whenever I tried to resend a confirmation email to a subscriber that was on a different list (which had its own confirmation email template), the subscriber was still receiving the other list’s email template. It was only after I dug quite deep into the code that I found a comment written on lines 250-251 of the lib/API/JSON/v1/Subscribers.php file that reads Per-list confirmation settings are not resolved for manual resends; the global default is used to avoid ambiguity across multiple segments. This information wasn’t available anywhere on the admin interface, which it should be.
    2. Related to the previous point, the “global default” template doesn’t seem like it can be updated from anywhere (e.g., via Settings > Sign-up Confirmation > Enable visual subscription confirmation emails). I had to dig into the database and update the setting manually to point to the other template in order to get it to do what I want. The Edit list view (via Lists > [List Name] > Edit) allows the admin to select (via a drop-down menu) which confirmation email should be associated with that list (and even create new ones), but they’re only available via these obscure settings; the Settings page I mentioned above should have a similar drop-down to allow the user to set which email is the global default, since it seems like they don’t get a choice of picking the template to use when manually resending confirmation emails.

      Similarly, I’m not sure why the confirmation emails are not shown under their own tab on the Emails page, seeing as they’re emails just like all the other ones. They should be added there for easy management of these emails.
    3. When a confirmation email is resent to a subscriber, the last_confirmation_email_sent_at value for that subscriber gets set to the current time, only to be inexplicably set back to the previous value upon the email being successfully sent. In the case of a subscriber who was manually added or imported, the value stays NULL all the time. However, the count_confirmations value gets incremented nevertheless, which makes no sense. This seems to be because of the code in the MailPoet\Subscribers\SubscribersRepository::completeAdminConfirmationEmailResendClaim method.

    I hope you can fix these bugs as soon as possible.

Viewing 1 replies (of 1 total)
  • Plugin Support Saravanan S, a11n

    (@simplysaru)

    2 days, 22 hours ago

    Hey there,

    thanks for the detailed report — very helpful!

    Quick summary of what you’ve flagged:

    1. No UI disclosure that manual resends use the global template, not the per-list one — this should be visible in the admin interface.
    2. No way to set the global default template from the UI — the Settings page needs a dropdown similar to what’s in Edit List view.
    3. Confirmation emails missing from the Emails tab — they should be there for easy management.
    4. last_confirmation_email_sent_at resets after a successful resend while count_confirmations still increments — looks like a bug in SubscribersRepository::completeAdminConfirmationEmailResendClaim.

    We haven’t reviewed these yet, but we’ll triage them and update this thread. In the meantime, we’d encourage you to open issues on GitHub if you are open to it.

Viewing 1 replies (of 1 total)

You must be logged in to reply to this topic.