• Resolved asherber

    (@asherber)


    I’ve got a menu where one of the menu items has a submenu underneath. This top-level menu item is defined as a custom link with a nav label but no URL — it’s not a link in itself, it’s just used to trigger the submenu.

    When this plugin is not installed, this menu item renders like this:

    <a>Links</a>

    When the plugin is installed, it seems to choke on the fact that there’s no href in this anchor. The anchor now renders like this:

    <a links<="" a="" data-wpel-link="internal">
    </a>

    Note that the text of the anchor has been moved inside the <a> tag, so that the menu item no longer displays on the page.

    • This topic was modified 6 years, 6 months ago by asherber.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Alexandru Tapuleasa

    (@talextech)

    Hi,

    Sorry to hear you’re having problems. We haven’t seen that issue before so I can’t say what’s causing it. Can you copy/paste the Tech Info from the Support tab of the External Links Settings page? Maybe we can recreate it locally and see what’s going on.

    Also, if you can send us a link to your page where this is occurring that would be awesome.

    Thread Starter asherber

    (@asherber)

    Hi,

    My site isn’t live yet, so I can’t send you a link — but if it helps, I’ve created a gist that has page source with the plugin off and plugin on, so you can see the effect and maybe run some tests on the “before” source. (By the way, I initially thought that the problem might be that the menu item in question is called “Links”, but I changed the name to something else and the issue persisted, so I’m pretty sure it’s the fact that there’s no href.)

    https://gist.github.com/asherber/19ac1fa9e87bf36aa10d84280dd0f6c7

    Here’s the support info:

    WP url: https://appalachianspring.info
    WP version: 5.3
    PHP version: 7.2.24
    Active Plugins:
    – Blocks CSS: CSS Editor for Gutenberg Blocks, version: 1.0.2
    – DreamHost Panel Login, version: 1.0.0
    – Jetpack by WordPress.com, version: 8.0
    – Maintenance, version: 3.85
    – PHP Everywhere, version: 2.0.1
    – Simple CSS, version: 1.1
    – WP External Links, version: 2.40
    – WPForms Lite, version: 1.5.6.2
    – WP Super Cache, version: 1.7.0

    WPEL Settings:
    array(
    ‘wpel-external-link-settings’ => array (
    ‘apply_settings’ => ‘1’,
    ‘target’ => ‘_blank’,
    ‘target_overwrite’ => ”,
    ‘rel_follow’ => ”,
    ‘rel_follow_overwrite’ => ”,
    ‘rel_noopener’ => ‘1’,
    ‘rel_noreferrer’ => ‘1’,
    ‘rel_external’ => ‘1’,
    ‘rel_sponsored’ => ”,
    ‘rel_ugc’ => ”,
    ‘title’ => ‘{title}’,
    ‘class’ => ”,
    ‘icon_type’ => ‘image’,
    ‘icon_image’ => ‘3’,
    ‘icon_dashicon’ => ‘dashicons-menu’,
    ‘icon_fontawesome’ => ‘fa-address-book’,
    ‘icon_position’ => ‘right’,
    ‘no_icon_for_img’ => ‘1’,
    ),
    ‘wpel-internal-link-settings’ => array (
    ‘apply_settings’ => ”,
    ‘target’ => ”,
    ‘target_overwrite’ => ”,
    ‘rel_follow’ => ”,
    ‘rel_follow_overwrite’ => ”,
    ‘rel_noopener’ => ‘1’,
    ‘rel_noreferrer’ => ‘1’,
    ‘title’ => ‘{title}’,
    ‘class’ => ”,
    ‘icon_type’ => ”,
    ‘icon_image’ => ‘1’,
    ‘icon_dashicon’ => ”,
    ‘icon_fontawesome’ => ”,
    ‘icon_position’ => ‘right’,
    ‘no_icon_for_img’ => ‘1’,
    ),
    ‘wpel-excluded-link-settings’ => array (
    ‘apply_settings’ => ”,
    ‘target’ => ”,
    ‘target_overwrite’ => ”,
    ‘rel_follow’ => ”,
    ‘rel_follow_overwrite’ => ”,
    ‘rel_noopener’ => ‘1’,
    ‘rel_noreferrer’ => ‘1’,
    ‘title’ => ‘{title}’,
    ‘class’ => ”,
    ‘icon_type’ => ”,
    ‘icon_image’ => ‘1’,
    ‘icon_dashicon’ => ”,
    ‘icon_fontawesome’ => ”,
    ‘icon_position’ => ‘right’,
    ‘no_icon_for_img’ => ‘1’,
    ),
    ‘wpel-exceptions-settings’ => array (
    ‘apply_all’ => ‘1’,
    ‘apply_post_content’ => ‘1’,
    ‘apply_comments’ => ‘1’,
    ‘apply_widgets’ => ‘1’,
    ‘skip_post_ids’ => ”,
    ‘ignore_classes’ => ”,
    ‘subdomains_as_internal_links’ => ”,
    ‘include_urls’ => ”,
    ‘exclude_urls’ => ”,
    ‘excludes_as_internal_links’ => ”,
    ‘ignore_script_tags’ => ‘1’,
    ‘ignore_mailto_links’ => ‘1’,
    ),
    ‘wpel-admin-settings’ => array (
    ‘own_admin_menu’ => ‘1’,
    ),
    );

    Plugin Author Alexandru Tapuleasa

    (@talextech)

    Hi,

    Yes, it looks like you called the issue correctly! It is happening when there’s no href attribute set for the anchor. We will fix the issue and update it as soon as possible (1-2 days).

    Thread Starter asherber

    (@asherber)

    Thanks!

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Conflict with nested menus’ is closed to new replies.