critical error after upgrading

  • Resolved Al.Janoubie

    (@janoubie)


    3 months ago

    After upgrading to v3.1.0, the website started to show “critical error” when trying to view any post.
    Posts only (and any post, even it was solo / without Series). the Pages / Categories are OK.

    I did some checks, trying to disable some features from the plugin which overlays the post content, but no luck. you had to disable the whole plugin to stop critical errors on viewing posts.

    I rolled back to v3.0.0, which works fine.

    Please Advice

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Riza Maulana Ardiyanto

    (@rizaardiyanto)

    3 months ago

    Hi @janoubie

    Did you happen notice the actual error? I can’t find this critical error in my testing yet.

    Plugin Author Riza Maulana Ardiyanto

    (@rizaardiyanto)

    3 months ago

    For reference, this is how to find the error: https://publishpress.com/knowledge-base/solve-errors-plugins/

    Thread Starter Al.Janoubie

    (@janoubie)

    3 months ago

    Hello @rizaardiyanto

    The function pp_series_group_theme_archive_excerpt() is hooked into the get_the_excerpt filter. In the latest update, this function was defined to strictly require two arguments. However, many themes and third-party plugins (like TaxoPress and Elementor) apply this filter using only one argument.

    Error Log Trace:
    Fatal error: Uncaught ArgumentCountError: Too few arguments to function pp_series_group_theme_archive_excerpt(), 1 passed in …/wp-includes/class-wp-hook.php on line 341 and exactly 2 expected in …/organize-series/addons/grouping/legacy-includes.php:452

    Steps to Reproduce:
    1. Use PublishPress Series v3.1 with the Grouping addon enabled.
    2. Use a plugin like TaxoPress (Related Posts) or Elementor (Post Content widget) that triggers the get_the_excerpt filter.

    The site crashes with a Critical Error when rendering the post.

    I have temporarily fixed this on my production site by making the second parameter optional in:
    wp-content/plugins/organize-series/addons/grouping/legacy-includes.php Line 452.

    Also, I did report it on Github, added the suggested fix, and asked for it to be included in the next maintenance release
    https://github.com/publishpress/publishpress-series/issues/1081

    Plugin Support Riza Prihananto

    (@rizaprihananto)

    2 months, 2 weeks ago

    Hi @janoubie ,

    Thank you for letting us know this information. That is so insightful. Since you have created a GitHub issue, we’ll update it there. However, if you have another concern, feel free to address it to us.

Viewing 4 replies - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.