CSS Override for Columns plugin | ww.wp.xz.cn

Resolved Patrick Johanneson
(@pjohanneson)

12 years, 11 months ago
In the Columns plugin, rather than dequeuing columns.css, would it be possible/sensible to allow themes to supply an override file by adding
```
wp_enqueue_style(
  'columns-override',
  get_stylesheet_directory_uri() .  '/columns-override.css',
  array( 'columns' )
);
```
to the enqueue_scripts function?

(Cross-posted to Trac — if it doesn’t belong here, please feel free to close or remove it.)

http://ww.wp.xz.cn/extend/plugins/columns/

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Author Konstantin Kovshenin
(@kovshenin)

12 years, 11 months ago

They can override by dequeuing what’s in columns.php. Or they can simply override the styles they need in their own stylesheet, maybe use !important where applicable. Having themes enqueue an extra stylesheet just for the columns layout is a little overkill, especially if you have to check it with file_exists first. Thoughts?

Thread Starter Patrick Johanneson
(@pjohanneson)

12 years, 11 months ago

I’m one of those people that thinks that if you need to use !important in a stylesheet, you’ve done something wrong. That’s where I like override stylesheets — especially considering you can tell WordPress what order they need to be loaded in.

I don’t know how expensive file_exists() is — according to a quick Google search, not very.

But in all honesty, you’re probably right — for a simple plugin, override stylesheets are probably overkill.

Plugin Author Konstantin Kovshenin
(@kovshenin)

12 years, 11 months ago

If you don’t like !important (I understand the reasons) you can just give it higher priority rule, like body .column 🙂

Thread Starter Patrick Johanneson
(@pjohanneson)

12 years, 11 months ago

I hadn’t thought of that. Thanks!

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘CSS Override for Columns plugin’ is closed to new replies.

Tags

CSS override

4 replies
2 participants
Last reply from: Patrick Johanneson
Last activity: 12 years, 11 months ago
Status: resolved