Deprecation warnings for nullables

Resolved

(@yogurt4)

matomo 5.6.0
The parameter types should be marked optional (?).

app/core/FrontController.php(588)
private function makeAuthenticator(SessionAuth $auth = null)

app/plugins/CoreAdminHome/Commands/RunScheduledTasks.php(26)
    public function __construct(LoggerInterface $logger = null)

app/vendor/wikimedia/less.php/lib/Less/Functions.php(12)
        function __construct($env, array $currentFileInfo = null)

app/core/Settings/Interfaces/Traits/PolicyComparisonTrait.php(37)
    public static function getPolicyValuesAgainstProvided($settingValue, int $idSite = null)

Viewing 5 replies - 1 through 5 (of 5 total)

Thread Starter yogurt4
(@yogurt4)

5 months, 3 weeks ago
Left out this one (may be more as I get code coverage):
```
app/core/Settings/Interfaces/PolicyComparisonInterface.php(25)
    public static function getPolicyValuesAgainstProvided($settingValue, int $idSite = null);
```
Thread Starter yogurt4
(@yogurt4)

5 months, 3 weeks ago
```
app/plugins/PrivacyManager/API.php(388)
    public function setComplianceStatus(string $idSite, string $complianceType, bool $enforce, string $passwordConfirmation = null) : bool
```
Plugin Support dizzyatinnocraft
(@dizzyatinnocraft)

5 months, 3 weeks ago

Hello @yogurt4, my apologies for not replying sooner, I had not received any notifications from ww.wp.xz.cn.

These code related issues are all related to the core Matomo product (anything in the app/ subfolder would be) which is handled by a different team. Could you report these issues here: https://github.com/matomo-org/matomo/issues ?

Thread Starter yogurt4
(@yogurt4)

5 months, 3 weeks ago

Did it here.

Plugin Support dizzyatinnocraft
(@dizzyatinnocraft)

5 months, 3 weeks ago

Thanks for creating that issue @yogurt4, when that team fixes it and releases a version, it will be included in Matomo for WordPress. I’ll mark this as resolved for now, the core issue you created should be the main way to track the status of this. If you need further help feel free to create a new issue or continue replying here.

Viewing 5 replies - 1 through 5 (of 5 total)

You must be logged in to reply to this topic.