Directories not created on replace
-
Hi,
I’m trying to use this plugin to replace missing media files after server data loss. The database is still intact, so it knows that the files used to exist.
In
classes/replacer.phpline ~86,move_uploaded_file()is used. However, this will not create the folder if it doesn’t already exist. Just before that file, this plugin should check if the directory exists and if not, create the directory.Something like the following, just before line 86, should solve the issue.
$targetFilePath = substr($targetFile, 0, (strrpos($targetFile, "/"))); if (!is_dir($targetFilePath)) { wp_mkdir_p($targetFilePath); } /* @todo See if wp_handle_sideload / wp_handle_upload can be more securely used for this */ $result_moved = move_uploaded_file($file,$targetFile);
-
Ok–figured out the issue.
In classes/replacer.php, getTargetFile() is not returning the correct path info for the destination in all cases. Sometimes, it’s returning:
/wp-content/uploads/[FILENAME]
rather than
[FULL PATH]/wp-content/uploads/[FILENAME]As a result, it’s trying to move the file to a directory that:
1. Doesn’t/shouldn’t exist
2. Doesn’t/shouldn’t have permission to access
3. Isn’t web accessibleAs a TEMPORARY and quick-and-dirty workaround, I added the following code at line 216:
// If the target file directory isn't QUITE right... $upload_dir = wp_upload_dir()['path']; if(substr($targetFile, 0, strlen($upload_dir)) != $upload_dir) { $targetFile = $upload_dir . '/' . pathinfo($targetFile)['basename']; }This fix will likely NOT work for others–but a fix is definitely necessary.
The topic ‘Directories not created on replace’ is closed to new replies.
