Divi theme & LSCache Optimisation Settings

  • Resolved Alex Kladov

    (@prowebassist)


    7 years, 4 months ago

    Hi,

    Your plugin claims that it’s fully compatible with the Divi theme. However, I noticed that styling breaks, if I enable all of the most useful CSS/JS Optimisation Settings.

    Do you have a recommendation for Divi powered websites as to what is safe to enable and what’s not?

    For example, I found out that I had to keep “Lazy Load Iframes” disabled, because core Divi modules would take ridiculous amount of time to load and would also often break styling (e.g. Blog module, post slider module etc)

    Regards,
    Alex

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support qtwrk

    (@qtwrk)

    7 years, 4 months ago

    Hi,

    Could you please provide report number ?

    Best regards,

    Thread Starter Alex Kladov

    (@prowebassist)

    7 years, 4 months ago

    Hi @qtwrk,

    I don’t have a report number. But you can replicate the problem by enabling “JS Combine” in LSCache Settings and then trying to open a saved Divi Library item.

    The builder will load forever. And there are errors in the console. For example:

    Uncaught SyntaxError: Unexpected end of input

    Regards,
    Alex

    Thread Starter Alex Kladov

    (@prowebassist)

    7 years, 4 months ago

    Hi @qtwrk,

    I just tried something, since I noticed that combined JS file does, indeed, end abruptly (hence why “Unexpected end of input” message). So I increased Max Combined File Size to 3MB and now backend Divi Builder is loading fine in Divi Library.

    Why would that be happening? Seems like as LSCache is splitting combined JS into multiple files, it’s breaking the JS code, since it just cuts right in the middle of the code, that’s very weird. Shouldn’t it combine files up-to, but no more than XX setting in Max Combined File Size instead? And if new JS doesn’t fit, it should push the it into the next file..

    UPDATE:
    Apparently, it wasn’t just the Max Combined File Size setting, which was causing the Divi Builder crashes. Setting Remove Comments to ON also breaks New Divi Builder. This is the console error message:

    Uncaught SyntaxError: Unexpected identifier

    Regards,
    Alex

    • This reply was modified 7 years, 4 months ago by Alex Kladov.
    Plugin Support qtwrk

    (@qtwrk)

    7 years, 4 months ago

    Hi,

    Yes ,sometimes if too many JS files to be combined , it will have a “huge” file may negatively impact the performance.

    Will set up and test it.

    So please confirm:

    remove comment ON -> breaks it

    Max combine size to 3 MB -> solves it

    if you do not combine JS , and only remove comment , does it break ?

    Best regards,

    Thread Starter Alex Kladov

    (@prowebassist)

    7 years, 4 months ago

    Hi @qtwrk,

    Yes ,sometimes if too many JS files to be combined , it will have a “huge” file may negatively impact the performance.

    It didn’t negatively impact the performance, it broke the JS scripts completely by splitting them right down the middle of the function, once the 1.2MB limit was reached. If the files were instead combined WHOLE, up to that set MB limit, then this wouldn’t happen. Yeah, the combined file might not be exactly 1.2MB, but at least it won’t have broken/cut-off JS functions in it.

    remove comment ON -> breaks it

    This breaks the code completely (if JS Minify is ON), regardless of the JS Combine setting. You will see the Uncaught SyntaxError: Unexpected identifier error.

    Max combine size to 3 MB -> solves it

    This solves the Uncaught SyntaxError: Unexpected end of input error. I would also advise anyone seeing this error, to actually increase the limit up to 4-5MB, because you need more space if you were to include jQuery in the mix.

    Regards,
    Alex

    Plugin Support qtwrk

    (@qtwrk)

    7 years, 4 months ago

    Hi,

    Could you please submit a ticket here ? we will investigate it deeper

    Best regards,

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Divi theme & LSCache Optimisation Settings’ is closed to new replies.