Doesn’t work, use my fixes

  • liubovwp

    (@liubovwp)


    7 years, 7 months ago

    Hello, great plugin! But, please, FIX IT:
    1. See file m-chart\components\class-m-chart-admin.php at line 309 replace
    $this->version with m_chart()->version
    2. See file m-chart\components\class-m-chart-chartjs.php at line 136 ADD CODE:
    if (isset($chart_args[‘data’][‘datasets’])) {
    …
    }
    3. See file m-chart\components\class-m-chart-admin.php at line 295 replace
    $post_id = (int) $_GET[‘post’];
    with
    $post_id = isset($_GET[‘post’]) ? (int) $_GET[‘post’] : ”;

    • This topic was modified 7 years, 7 months ago by liubovwp.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter liubovwp

    (@liubovwp)

    7 years, 7 months ago

    In addition:
    3. See file m-chart\components\class-m-chart-admin.php at line 295 replace
    $post_id = (int) $_GET[‘post’];
    with
    $post_id = isset($_GET[‘post’]) ? (int) $_GET[‘post’] : ”;

    Plugin Author methnen

    (@methnen)

    7 years, 7 months ago

    Hey @liubovwp,

    Thanks a ton for the fixes. You’re welcome to submit things like that via a pull request to the GitHub repository in the future:

    https://github.com/methnen/m-chart/

    GitHub also alerts me immediately whereas ww.wp.xz.cn does not so that’s a side bonus.

    I’ll test these and get these in shortly. It’s possible one of these is related an issue I’ve been unable to reproduce that some users are having.

    Thanks again.

    • This reply was modified 7 years, 7 months ago by methnen.
Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Doesn’t work, use my fixes’ is closed to new replies.