Drop Query String Option not saving in Network installation

Resolved Jory Hogeveen
(@keraweb)

8 months ago
Hi team,

My guess is that this is quite a simple Network vs Single installation bug which is probably just an option reference that needs to be updated in the code.

When in network mode, the “Drop Query String” Cache option cannot be saved, I also cannot see it in the database (prefix_sitemeta), but only in the site specific options table (prefix_options).

Even when manually copying the contents from options to sitemeta it didn’t show on the page settings. (key: litespeed.conf.cache-drop_qs)

Cheers, Jory
- This topic was modified 8 months ago by Jory Hogeveen.

Viewing 8 replies - 1 through 8 (of 8 total)

Plugin Support litetim
(@litetim)

8 months ago

@keraweb Thank you for report.
I started debugging it. I was able to reproduce the issue on my test site.
I will keep you up to date when I have news

Plugin Support litetim
(@litetim)

8 months ago

@keraweb I have found the cause and added a fix here: https://github.com/timotei-litespeed/lscache_wp/commit/98a306d5bae54ed279979d58e3431dfb4cc0a77b
Are you able to manually make the change and test the fix yourself?

Thread Starter Jory Hogeveen
(@keraweb)

8 months ago

Hi @litetim

I can confirm the fix works, thank you!
One thing that I noticed is that the default value is now missing from this field.

See default for singular site: https://github.com/timotei-litespeed/lscache_wp/blob/b93ae3385229e53ce0865c1ed0e1d7d444b94ac9/data/const.default.ini#L160

All the best, Jory

Plugin Support litetim
(@litetim)

8 months ago

@keraweb This setting cannot be changed from single site. It’s a general setting on all instances

Plugin Support litetim
(@litetim)

8 months ago

@keraweb the fix will be applied to next version that will be released 🙂

Thread Starter Jory Hogeveen
(@keraweb)

8 months ago

Hi @litetim

I understand that, but after I’ve added that line of code it defaults to an empty array, not the usual default value: https://github.com/timotei-litespeed/lscache_wp/blob/b93ae3385229e53ce0865c1ed0e1d7d444b94ac9/data/const.default.ini#L160
Therefore I manually entered this default value (including my additions) and after that the DB value (sitemeta) was created.

In short, the added line fixes saving the value, however, for existing installations, this is not backwards compatible as it will remove the defaults settings.
For me this issue is fixed, I just wanted to prevent other users from having issues after updating, and with that, save you time on new support requests.

Cheers, Jory

Plugin Support litetim
(@litetim)

8 months ago

@keraweb added: https://github.com/litespeedtech/lscache_wp/commit/0b72955914fe0baa1af7970f8b2cf33f8a192bab
🙂

Thread Starter Jory Hogeveen
(@keraweb)

8 months ago

@litetim Perfect! Thank you for your fast response and help!

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘Drop Query String Option not saving in Network installation’ is closed to new replies.