Hi Fritz,
Glad to know you like the plugin!
Regarding this issue, I’m not really sure. Might be a bug in the plugin but can’t reproduce it myself so I’ll need your help:
- Optional, but recommended: Create a full backup of your website (database and files).
- Enable WordPress’ debug mode (make sure WP_DEBUG_LOG is also set to
true, we’ll need this.)
- Go to WP Dashboard > Plugins > Plugin Editor, select WordPress Popular Posts using the dropdown at the right.
- Click on src/Image.php to edit this file.
- Replace its contents with this version, then scroll down and click on the Update File button to save changes.
- Go to WP Dashboard > Settings > WordPress Popular Posts > Tools, then under Thumbnails click on the Empty image cache button to delete all of WPP’s cached thumbnails.
- Clear your site’s cache.
- Visit your site’s homepage. WPP’s widget will load after a couple of seconds and new thumbnails will be created. The “dropped srcset candidate” issue will still be there, don’t worry, we’re just debugging at the moment so I can understand what’s going on.
- Upload the contents of your debug.log file (located at /wp-content) to pastebin.com and share the URL here so I can have a look.
Thread Starter
fredel
(@fredel)
Hey, sure & thanks 🙂
Link is: https://pastebin.com/w8zenVcM
Thread Starter
fredel
(@fredel)
May i deactivate the Debug?
Yep, you can disable the debug mode. And thanks, that helped!
Alright, I’ll test some ideas and leave a comment here if/when I need your help again. For the time being please add this code snippet to your theme’s functions.php file:
/**
* Disables WPP's retina display support.
*
* @param bool $enabled
* @return bool Whether retina display support is enabled or not
*/
function disable_wpp_retina_support( $enabled ){
return false;
}
add_filter( 'wpp_retina_support', 'disable_wpp_retina_support' );
When you’re done please clear your site’s cache for these changes to take effect.
Thread Starter
fredel
(@fredel)
hey & thx so much, done that fix but seems it doenst work yet? 😉 best
Not really a fix though. It’s just a temporary workaround (hence the “For the time being…” part :P)
Thread Starter
fredel
(@fredel)
yeah sorry ;)) thanks again🙏
Alright, I think I know what the problem is. This patch should fix it but I’ll need your help to confirm, @fredel. Would appreciate it if you could try it out for me 😀
- Go to WP Dashboard > Plugins > Plugin Editor, select WordPress Popular Posts using the dropdown at the right.
- Click on src/Image.php to edit this file.
- Replace its contents with this new version, then scroll down and click on the Update File button to save changes.
- Go to WP Dashboard > Settings > WordPress Popular Posts > Tools, then under Thumbnails click on the Empty image cache button to delete all of WPP’s cached thumbnails.
- Remove this from your functions.php file (or comment it out.)
- Clear your site’s cache.
- Visit your site’s homepage. WPP’s widget will load after a couple of seconds and new thumbnails will be created again.
Please report back your results. Hopefully this will fix the srcset issue!
Thread Starter
fredel
(@fredel)
hey, looking good!! Thanks a lot, seems to be fixed! Where can i donate 🙂 Best
That’s fantastic news! Thanks for reporting back, @fredel
Alright, I’ll make sure to include this patch on the next release so please update as soon as it becomes available.
Where can i donate 🙂
Thanks! You can Buy me a Coffee or use the good old Donate button located at the right of the Description page of the plugin (you may need to scroll down a little to see it).
Thread Starter
fredel
(@fredel)
thanks for having coffee with me 🙂
best
Thank you for being an awesome human being!
