Duplicate panel ID’s / Same layout for all tabs

  • nelsondaniel

    (@nelsondaniel)


    9 years, 6 months ago

    Hi,

    Thanks for a great plugin!

    I’m having some issues with creating different column layouts for two tabs. When I checked the code I noticed that the panel-grid-cell’s under each tab have the same ID, which forces contents of tab 2 to have the layout of tab 1.

    Setting a custom row ID on the rows on tab 2 of course forces the ID’s to be different, but then the appended CSS isnt updated so all the columns have a default width of 100%.

    Any thoughts on how this could be solved would be highly appreciated! 🙂

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor Gregor Capuder

    (@capuderg)

    9 years, 6 months ago

    Hi,

    I just tested this and the panel-grid-cell are all different (unique). You can build any layout (any number of columns) for each tab.

    Maybe I didn’t understand your problem exactly, but what you are saying is that you can’t create different layouts (different column layout) for each tab in the widget? If that’s correct, then I can’t recreate this issue on my site.

    Could you maybe tell me the URL of your site, so I can take a look at this problem?

    Also are you using the latest version of this plugin and the page builder plugin?

    Take care!

    Thread Starter nelsondaniel

    (@nelsondaniel)

    9 years, 6 months ago

    Hi again,

    Thanks for your reply!

    Yes, that’s correct. I’m unable to create different layouts for the different tabs. If I dont set a Row ID, tab 2 takes the same layout as tab 1(since tab 2 doesnt get an unique ID for some reason).

    And if I manually set the Row ID’s they’re of course unique, but then the appended CSS(in siteorigin-panels-grids-wp_footer) isnt updated. Therefor all the columns gets the default value of 100%.

    It’s a really strange issue. I have the latest versions of(and have reinstalled) the plugins and WordPress. Have even tried using standard WP-themes and disabling the few every plugins in use, without any difference.

    I’m using the tabs on a custom post type, but that should matter either since I tried it on a page as well with the same result. So I dont get why it seems to be working everywhere else but not here.

    The site is currently only running on my local machine via WAMP, so unfortunetely I cant give you an URL. But here a image of how it looks when tab 2 has a unique Row ID: Tabs

    If only I could force the appended CSS to include the specified Row ID’s I could get everything to work as desired.

    Cheers!

    Thread Starter nelsondaniel

    (@nelsondaniel)

    9 years, 6 months ago

    Here an image of the duplicate panel-grid-cell ID’s in the code:
    Code

    So since that occurs it’s quite logic that the two layouts are identical.

    • This reply was modified 9 years, 6 months ago by nelsondaniel.
    Thread Starter nelsondaniel

    (@nelsondaniel)

    9 years, 6 months ago

    Hmm, I might finally be on to something here…

    In class-tabs-widget.php at line 68 you loop through the created items and echo out whatever’s returned from siteorigin_panels_render(). From what I can see you send in the same $post_id for all of the tabs, resulting in them getting the same id once rendered. I tested to append a unique value to the variable and that actually worked for me. Don’t know what other consequences it might have, but now I’m finally able to have different column layouts on each of the tabs. 🙂

    Code

    Plugin Contributor Gregor Capuder

    (@capuderg)

    9 years, 6 months ago

    Hi,

    the page builder is responsible to generate these ids, so I think this might be connected to your environment/server setup… It is very strange. I looks like page builder uses the uniqid PHP method to generate these unique ids and this method generates these strings depending on the server time, so maybe that’s the issue here? I don’t know.

    This is the first time I see this issue and other users would definitely report it, if this would be a plugin bug.

    Anyway here are the IDs from our theme Beauty (the first tabs widget is the one with title “Pricing”): https://demo.proteusthemes.com/beauty

    You will see that they are unique. Here is an image also:
    tabs source code

    Could you please try to test this plugin online on your hosting server? I think that this should not occur on your server.

    Let me know how it goes.

    Take care!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Duplicate panel ID’s / Same layout for all tabs’ is closed to new replies.