Editor ‘Edit image’ broken

  • Resolved Dawid

    (@davidcie)


    9 years, 8 months ago

    This is not directly related to this plugin but hoping the author has the best chance of nailing down the problem. When I add an svg image to page or post content using built-in WordPress’ ‘Add Media’ button I am able to edit the css class and alignment. However, once the post or page is published or you come back to edit content later, select the image and hit the ‘Edit’ button that appears above it, an image editing popup is displayed but without any content.

    The following message appears in console: “Cannot read property ‘full’ of undefined”. Looking at the code this is related to available image sizes; it seems WordPress did not envision images not conforming to the standard thumbnail/size framework.

Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Author Benbodhi

    (@benbodhi)

    9 years, 8 months ago

    Hey Dawid,

    Thanks for your support!

    This is an interesting use case. I will try to reproduce and track down the problem.
    I’m working on a new version at the moment, so if it’s something I can fix on my end, I will try to include it in the next release.

    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 8 months ago

    So upon checking,

    • I created a new post
    • Pressed Add Media
    • Uploaded and SVG
    • Inserted it into post
    • Clicked the image in the content editor
    • Clicked the “Edit” pencil Icon
    • Could see the SVG in there…

    It sounds like it may be due to your actual SVG file’s code or a conflicting plugin.
    Let me know if I didn’t follow the right steps to reproduce the issue.

    Thread Starter Dawid

    (@davidcie)

    9 years, 8 months ago

    @benbodhi thanks for trying to verify that. (Shame I did not enable notification of a reply btw!) The key is to publish the post and then try to edit the image in question. So the steps should be:

    1. Create a new post
    2. Add Media
    3. Upload an SVG
    4. Insert it into post
    5. Publish the post
    6. Click the image in the content editor
    7. Click the “Edit” pencil Icon
    8. The popup should be empty
    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 8 months ago

    Hey @dawid,
    Thanks for getting back to me. I can confirm this same behaviour on pretty standard install. I will look into it as soon as possible.
    I haven’t come across this because I have never actually edited an SVG in the content editor after saving/publishing a post before. Thanks for pointing it out.

    I’ll keep you updated when I know more.

    Thread Starter Dawid

    (@davidcie)

    9 years, 8 months ago

    Glad you could repro. I agree editing is seldom used but can come in handy when you need to edit the caption or add a class.

    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 8 months ago

    Totally, just because I use the text editor for everything… I’m sure a huge amount of people use the visual editor and it should certainly work in there.
    That is a side note, you can make your edits in the text editor until I provide a fix for this issue.

    Thread Starter Dawid

    (@davidcie)

    9 years, 8 months ago

    Yes, this is what I told the client to do before this gets fixed 🙂

    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 8 months ago

    So after some testing, I found that it only happens the first time you click the pencil.
    So if you click the pencil, then outside the blank screen to close it, then on the pencil again, it works.
    Very strange behaviour. I’ll keep digging.

    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 4 months ago

    This seems to be resolved now, whether it was a core update or some of my recent updates, I’m not sure.
    I went to fix this and all my tests worked out as they should.
    Please let me know if you still see this behaviour with the latest version of the plugin (2.3.2) and WP 4.7.1

    Thread Starter Dawid

    (@davidcie)

    9 years, 4 months ago

    @benbodhi, you are right — editing svg image properties works fine on the first try now. Glad this kind of resolved itself and we can go back to enjoying both WP and SVG Support. Thank you for your time spent looking into this.

    Plugin Author Benbodhi

    (@benbodhi)

    9 years, 4 months ago

    No problem! I’m glad you got the same result. Thanks for letting me know.

Viewing 11 replies - 1 through 11 (of 11 total)

The topic ‘Editor ‘Edit image’ broken’ is closed to new replies.