Don’t want to ruin the party but, the site I am having problems with is a standalone installation! No Multi-Site installation involved.
wn nj
(@waseemnaikgmailcom)
yes, but it may be that your host has actually a multisite installed and you have access to only your portion of the install and therefore it appears as a single install.
I have confirmed the issue with a standalone install in my case. the changes got saved.
These sites are on a managed VPS server?
wn nj
(@waseemnaikgmailcom)
well, not to speculate in the dark, let’s wait for the new patch and see if this addressees the issues.
Hi Yorman,
Is the patch to the problem on multi-sites.
I will add the patch for this bug to the development repository so you can replace the current plugin with the development version, do not download that archive now, I would like to polish the code a little bit, maybe at the end of the day or tomorrow.
Can you go ahead and download the patch and install it? It is stable enough to be installed on production sites?
One other thing i picked is that even when you uninstall the plugin one would still get the email notifications. Aren’t you supposed to remove the cron events associated with a plugin when that plugin in uninstalled and arent you supposed to remove the entries of a particular plugin in options table when that plugin is uninstalled?
Thanks for your help and thank for the wonderful plugin.
@kirsten-sadev Our QA team is still reviewing the changes so I would not say that the development version of the plugin is stable, but I have been using it for the last month and everything seems to work correctly. You can install it in a test site and see how it behaves, this is the archive [1].
Regarding the email notifications, technically speaking there is no way to send email notifications if you uninstalled the plugin, and with “uninstalled” I mean that you not only deactivated the plugin but also deleted all its files from your server. The method that WordPress uses to execute an scheduled task is very primitive and relies on the existence of the plugin to actually do something, so (again) technically speaking you should not be receiving those messages. It is probable that the plugin generated too many messages when it was active and the mail server was not able to handle that quantity so they remained in a queue, if there are sufficient messages in that queue it does not matter if you uninstalled the plugin because you will receive these messages until the queue is cleared.
As for the uninstallation process, the plugin used to delete its data from the database on its deactivation, but people started to complain that their API key and security logs were deleted when they reactivated the extension, I did not want to fight this people because it is hard to explain something like this without technicalities. I will think about this a few days, if I find a solution to help you without affect this people then I will add it to the plugin as soon as possible.
[1] https://downloads.wp.xz.cn/plugin/sucuri-scanner.zip
wn nj
(@waseemnaikgmailcom)
Yorman, Is there a long review process?
Considering how responsive you were, the QA are on slow cycle?
Thanks
@wn nj yes the process is very long because the QA team check if there are vulnerable points in the code too. Checking the five latest commits since version 1.7.5 from here [1] you can see that there were a lot of changes, there were also suggestions from our marketing team so we have to wait for the approval of both teams to release version 1.7.6.
Last time, the review process lasted two months, this is the difference between the development of this plugin and others, developers generally release a new version with (almost) every modification in the code, in the other hand we release a new version after (approximately) 10-20 changes. That is also the reason of why our plugin is still in version 1.x.x when other plugins are over version 4.x.
Note that I work in an internal repository so you can not see the real tree of commits, I only push the changes to the WordPress subversion repository when I do merges which are usually less than five. Each commit in this repository represents five to ten commits in our internal system.
[1] https://plugins.trac.ww.wp.xz.cn/log/sucuri-scanner/
I installed the updated version today, but the Failed log in attempts are still being sent.
wn nj
(@waseemnaikgmailcom)
has it been released? I have not see it in the updates as of now?
Just wanted to inform you that the email notifications about ‘failed log ins’ seemed to have ended. I installed the update Jan 21 and the nothing worked at first but I just realized that the messages have stopped as of Friday Jan 30th. So it took a week for the changes to be effective?
wn nj
(@waseemnaikgmailcom)
if you changed nothing and it stopped by itself, there is a problem somewhere else.
just a thought.
fyi, I am still waiting for the official release !
You are misreading the update. I did install the new version it just seems like it took a week for it to have an effect. Maybe it has something to do with the server, but that is above my pay grade.
