Empty google font import

  • Resolved fireemerald

    (@fireemerald)


    6 years, 1 month ago

    It is possible that your plugin creates an empty import statement:
    <link href="//fonts.googleapis.com/css?family=" rel="stylesheet">

    This is because of the function blocks_google_font inside class-uagb-helper.php.

    If the parameter $font_family is “”, you still add the non-existent font to the collection. (https://i.imgur.com/G4CQcQy.png)

    The error occurred because of this line inside a page:
    <div class="wp-block-uagb-column uagb-column__wrap uagb-column__background-undefined uagb-block-c82f0a92-42e9-4221-88e1-669dc2738d29"><div class="uagb-column__overlay"></div><div class="uagb-column__inner-wrap"><!-- wp:uagb/info-box {"classMigrate":true,"headingAlign":"left","icon":"","prefixFontSize":20,"prefixFontFamily":"","prefixFontWeight":"","prefixFontSubset":"","headingTag":"h2","headFontFamily":"","headFontWeight":"","headFontSubset":"","subHeadFontFamily":"","subHeadFontWeight":"","subHeadFontSubset":"","headSpace":21,"subHeadSpace":44,"seperatorSpace":30,"block_id":"ab45c9cd-ed06-4977-85c6-ddc600d2e1c3","seperatorWidth":10,"ctaType":"button","ctaText":"About me","ctaLink":"about-me","ctaFontFamily":"","ctaFontWeight":"","ctaFontSubset":"","ctaLoadGoogleFonts":true,"ctaBtnLinkColor":"#ffffff","ctaLinkHoverColor":"#ffffff","ctaBgColor":"#da578d","ctaBgHoverColor":"#d8673d","ctaBorderStyle":"none","ctaBtnVertPadding":15,"ctaBtnHrPadding":40,"ctaBorderRadius":50,"prefixSpace":0} -->

    I don’t know how i generated the line via the visual editor. As quick fix i removed "ctaLoadGoogleFonts":true.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support Team Brainstorm Force

    (@brainstormteam)

    6 years, 1 month ago

    Hello @fireemerald,

    I’m sorry, we have tried to replicate the issue at my end, but we’re not able to see any issue.

    Could you please open a ticket with us from here, so that we can have a closer look?

    Looking forward to resolving your issue.

    Regards,
    Sweta

    Thread Starter fireemerald

    (@fireemerald)

    6 years, 1 month ago

    As i wrote i was also unable to re-create a broken block.

    But anyway you should not allow a empty font to be added.
    Add a check inside the function: https://i.imgur.com/OtcAyQl.png

    Input should be always validated – you don’t do that at the moment.

    • This reply was modified 6 years, 1 month ago by fireemerald.
    Plugin Support Team Brainstorm Force

    (@brainstormteam)

    6 years, 1 month ago

    Hello @fireemerald,

    I will surely convey your feedback to our concerned developers. We are always keen to listen to our customers and to receive their feedback. This is the best way to improve our products and services and maintain our client’s satisfaction. 🙂

    I’ll put forward your thought about this to our team and if feasible we will try to improve the scenario our future updates.

    If you have any further queries, please don’t hesitate to contact us.

    Regards,
    Sweta

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘Empty google font import’ is closed to new replies.