Error On Plugin Activate With WP 3.9.2

  • Resolved Run Buff

    (@run-buff)


    11 years, 9 months ago

    Hi,
    When I first downloaded and tested this plugin it worked great. I had deactivated to wait until my novel came out, which its about to do, but in reactivating today it it no longer works with the updated 3.9.2 WordPress. Here is the error message that runs at the top of all my website pages. I uninstalled and reinstalled the plugin, but the same results occurred. Thoughts?

    Notice: wp_dequeue_style was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks

    Regards,
    Ty

    https://ww.wp.xz.cn/plugins/goodreviews/

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author jhanbackjr

    (@jhanbackjr)

    11 years, 9 months ago

    Hello, Ty.

    Thanks for trying GoodReviews.

    I have not seen that error before. It might be a bug in the plugin, but I’ll need a little more information to try to reproduce it on my side.

    You mentioned that you’re using WP 3.9.2. Let me know what version of the plugin you’re using and what customizations you’ve made to the settings (if any). For example, have you configured the “Custom CSS URL” field or the “Use Responsive Style” field?

    Thanks again and let me know.

    James

    Plugin Author jhanbackjr

    (@jhanbackjr)

    11 years, 9 months ago

    Hello, Ty.

    Actually, disregard my request for more information. I was able to reproduce the bug and I know the cause. I will have it fixed for the next release. I will leave this topic open until the next release is stable.

    If you need a fix immediately and you are comfortable modifying code, let me know and I’ll send you some instructions.

    Thanks again for using GoodReviews.

    James

    Thread Starter Run Buff

    (@run-buff)

    11 years, 9 months ago

    Hi James,
    I’m glad you were able to replicate it. Yes, if you don’t mind sending along some instructions for a temp fix until the next update that would be great. I am a developer by trade so I’m comfortable with coding.

    Regards,
    Ty

    Plugin Author jhanbackjr

    (@jhanbackjr)

    11 years, 9 months ago

    Hi, Ty.

    No problem. The following should work as a temporary fix until the next version becomes available.

    In goodreviews.php, comment out or delete this line:

    $jhgrOpts->jhgrRequireStyles();

    Replace that line with this one:

    add_action('wp_enqueue_scripts',array(&$jhgrOpts,'jhgrRequireStyles'));

    The problem is that GoodReviews was not actually calling wp_enqueue_scripts prior to attempting to register/enqueue its default CSS or any custom CSS specified in the preferences. If you don’t have WordPress debugging enabled, you won’t notice this because the error does not get reported and the style sheet registers/queues anyway. If you enable WordPress debugging, the missing wp_enqueue_scripts call creates the behavior you experienced.

    This issue is fixed in the latest development version and will appear in the next stable release. Let me know if the above temporary fix does not resolve the issue for you.

    Thanks.

    James

    Thread Starter Run Buff

    (@run-buff)

    11 years, 9 months ago

    Thanks, James.
    That removed the original issue, but it brought up another:

    Undefined index: restore_jhgrNotices in /home/tystrang/public_html/WP_1/wp-content/plugins/goodreviews/jhgrclasses.php on line 89

    So that you’re not spending time on trying to spot fix this for me, I’ll wait until the next update is available and go with that. I can use some of GoodReads basic code from their site in the meantime.

    Thanks for looking into this for me.

    Regards,
    Ty

    Plugin Author jhanbackjr

    (@jhanbackjr)

    11 years, 9 months ago

    Hi, Ty.

    Thanks. The undefined index has actually already been fixed in development, so that fix will also be available in the next release.

    James

    Plugin Author jhanbackjr

    (@jhanbackjr)

    11 years, 9 months ago

    Hello, Ty.

    The issues you encountered with version 2.0.1 have been solved in version 2.1.0, which is now available for download. I’m marking this topic as resolved. Thanks for using GoodReviews and let me know if I can be of further assistance.

    James

Viewing 7 replies - 1 through 7 (of 7 total)

The topic ‘Error On Plugin Activate With WP 3.9.2’ is closed to new replies.