Thanks for catching that. My PHP is at 7.2.24 and does not throw an error, even though I believe it probably should.
Without getting too much into the weeds, I was using a constant named ATTRB_MARKUP_DESC_END, when I should have used one named ATTRB_MARKUP_END. Long story, but it essentially works the same regardless if the constant is spelled correctly or not. The constant was coded as a fail-safe, but caused an error of its own in some versions of PHP.
I’ve fixed it and will be test and roll out the fix by the end of day.
EDIT: Sorry, the reason it didn’t throw an error is because it is in a database update routine that only is run once if you are at an old version of the database. No wonder it didn’t show up in testing.
Hi Mark,
Thank you very much for your response and for the update on the plugin. However, I am still throwing the errors below. Should I just switch the version of my php?
Warning: Use of undefined constant ATTRB_MARKUP_DESC_BEG – assumed ‘ATTRB_MARKUP_DESC_BEG’ (this will throw an Error in a future version of PHP) in /home/laparisc/public_html/wp-content/plugins/markup-by-attribute-for-woocommerce/src/utility/general.php on line 73
Warning: Use of undefined constant ATTRB_MARKUP_END – assumed ‘ATTRB_MARKUP_END’ (this will throw an Error in a future version of PHP) in /home/laparisc/public_html/wp-content/plugins/markup-by-attribute-for-woocommerce/src/utility/general.php on line 73
Warning: Cannot modify header information – headers already sent by (output started at /home/laparisc/public_html/wp-content/plugins/markup-by-attribute-for-woocommerce/src/utility/general.php:72) in /home/laparisc/public_html/wp-includes/functions.php on line 6270
Frustrating.
So, I’m consolidating all the definitions of the constants to a single routine, right up front. That should take care of it. I’ll have that ready within a few hours.