This is the code of wppaInitOverlay():
function wppaInitOverlay() {
wppaConsoleLog('wppaInitOverlay', 1);
var anchors=jQuery('a');
var anchor;
var i;
for(i=0;i<anchors.length;i++) {
anchor = anchors[i];
if (anchor.rel) {
temp = anchor.rel.split("[");
if (temp[0] == 'wppa') {
wppaWppaOverlayActivated = true; // found one
anchor.onclick = function () {return wppaOvlShow(this);}
}
}
}
wppaOvlRunning = false;
}
and event.returnValue or returnValue does not appear anywhere in my code, so i do not know what the errormessage means…
On a 2nd thought: Try this:
change:
anchor.onclick = function () {return wppaOvlShow(this);}
into:
anchor.onclick = function () {wppaOvlShow(this);}
and test if the lightbox functions still work!!
Edit wppa.js ( around line 3099 ) and delete wppa.min.js !!
Jacob,
Thank you so much for your quick reply. I’ve changed the code in wppa.js as you mentioned and I deleted the wppa.min.js file too. The error is still popping up when I use Google’s Inspect Element and click on the Console tab. But, what I was essentially trying to do has been accomplished somehow. I am now getting the green lock beside my url address which is what I was going for. I’m still unsure about the error, but at least I’m not getting the yellow lock or red slash through my https which was looking horrible to my visitors/customers.
I’m not sure how to test the lightbox function, but all photos and widgets seem to be working just fine still.
Thank you so very much for your time and help!!
Thank you for this usefull info. I will go into this problem later and fix it – if i can – in a later version. At least you pointed me the into the right direction to find the source of the ‘Please use the standard event.preventDefault() instead.’ – message that i have seen before but did not associate to wppa+.
This thread closed for now.
Please be so kind to test the following:
function wppaInitOverlay() {
wppaConsoleLog('wppaInitOverlay', 1);
var anchors=jQuery('a');
var anchor;
var i;
for(i=0;i<anchors.length;i++) {
anchor = anchors[i];
if (anchor.rel) {
temp = anchor.rel.split("[");
if (temp[0] == 'wppa') {
wppaWppaOverlayActivated = true; // found one
jQuery(anchor).click(function(event){
wppaOvlShow(this);
event.preventDefault();
});
}
}
}
wppaOvlRunning = false;
}
This should be the final fix.
Jacob,
Sorry it took so long to get back with you. I would be happy to test it out. My only question would be do I replace the whole code or just the part of it? Please remember that I’m that tech savvy yet, plus I don’t want to make a mistake I can’t fix either..
Just let me know if I need to replace the whole function in my file with the one above or just part of it.
Once again, I appreciate the help on this too!
Have a great day,
James.
The easiest way ( to prevent edit errors ) is to replace the entire function.
If you place /* before, and */ after the original function, it is ‘commented away’ but not removed, so you can – if that would be nedded – undo your changes easily.
So, do the following:
put /* just before the current function wppaInitOverlay() {
and */ just after the last } of the current function.
Then copy the above code, and paste it right after the */ you entered.
Now the new function will be the one that is used.
Alway press CTRL+F5 in the browser to make sure the modified version of wppa.js will be loaded into the browser ( clears the browser cache ).
Jacob,
Hi there. I just tried the above code and after clearing my cache and looking at Google’s Inspect Element these are the errors I’m seeing now:
Uncaught SyntaxError: Unexpected token function wppa.js:3115
Uncaught ReferenceError: wppaTickImg is not defined wppa-init.en.js:65
Uncaught ReferenceError: wppaAutoColumnWidth is not defined (index):170
Uncaught ReferenceError: wppaAutoColumnWidth is not defined (index):216
event.returnValue is deprecated. Please use the standard event.preventDefault() instead.
Please do let me know what you think about this as I have no clue what these errors means.
Also, the autocolumnwidth errors were not there before. They just started with the above code that I added.
I’ll leave it like this, and I do believe that the plugin should be in debug mode if you want to take a look. Here’s the page of the site with the errors, https://www.grocerycomping.com/photos
If you have any more I ideas, please do let me know.
Have a great day,
James.
You made a mistake:
change:
function /* wppaInitOverlay() {
into:
/* function wppaInitOverlay() {
that should be all
Jacob,
I apologize for not getting back with you sooner. So far I’ve updated to v5.3.0. I am still using WP v3.8.3 as I haven’t updated to v3.9 yet. I fixed the /* mistake I had in the wppa.js file and I’ve re-added the code from above. I also deleted the wppa.min.js file too. I am still seeing the error in the Console section of the Inspect Element tool. It’s really not hurting anything on my site at the moment, so I’m going to leave it this way in case you want to have another look.
Once again, thank you so very much for your time and help,
James.
If you dare, update to 5.3.1 when it is available, it’s in there, and the browser will load it and not use the old version.
Jacob,
Hi there. I just updated to v5.3.1 and the error remains. Actually it’s not even coming up as an error but just a warning. Everything seems to be working just fine too, so I’m really not going to worry to much about it right now unless it moves over to becoming an error instead of just a warning.
Thanks so much for your help on this.
Have a great day,
James.
Jacob,
I’m sorry to have to bother you again, but I wanted to ask a question. I’m noticing that the wppa.min.js file has returned with the v5.3.1 update. Would it be recommended to delete this file again or just leave it as it is.
The reason I am asking is because now I don’t have the green lock beside my https url. Not it’s the yellow warning lock instead.
https://www.grocerycomping.com
Please let me know what you think.
Have a good one,
James.
wppa.min.js is also updated. Only delete it when you want to change wppa.js
If i open the link, it says Passed in green at the right hand bottom of the screen.
Jacob,
Thank you so much for your help and for taking the time to explain different things along the way. I really appreciate that!
Yea, I noticed the lock had changed back to green last night. I guess my server needed a bit more time to reflect the update than what I was giving it.
Once again, thank you for your time and help,
Have a great day,
James.
I’m glad i could fix it for you and the rest of us…
