Errors on 2.2.2

Looking at their public code it could simply be that they are using composer without prefixing, resulting in duplicate classes being loaded at points.

Composer is a great tool, but its meant to be used once within a project, not once in each plugin. Because of this we have to prefix every class with a custom namespace so they aren’t all colliding.

I see they have vendor folders but none are prefixed with a custom namespace which is the only way to do it safely in WordPress to prevent collisions.

For example both of our plugins use the composer Pimple container package. But you can see their version is exactly the way it comes from Pimple

• https://plugins.trac.ww.wp.xz.cn/browser/wp-simple-firewall/trunk/src/lib/vendor/pimple/pimple/src/Pimple/Container.php

27      namespace Pimple;
28	
29	use Pimple\Exception\ExpectedInvokableException;
30	use Pimple\Exception\FrozenServiceException;
31	use Pimple\Exception\InvalidServiceIdentifierException;
32	use Pimple\Exception\UnknownIdentifierException;
33	
34	/**
35	 * Container main class.
36	 *
37	 * @author Fabien Potencier
38	 */
39	class Container implements \ArrayAccess

And ours:

• https://plugins.trac.ww.wp.xz.cn/browser/content-control/tags/2.2.2/vendor-prefixed/pimple/pimple/src/Pimple/Container.php

29	namespace ContentControl\Vendor\Pimple;
30	
31	use ContentControl\Vendor\Pimple\Exception\ExpectedInvokableException;
32	use ContentControl\Vendor\Pimple\Exception\FrozenServiceException;
33	use ContentControl\Vendor\Pimple\Exception\InvalidServiceIdentifierException;
34	use ContentControl\Vendor\Pimple\Exception\UnknownIdentifierException;
35	
36	/**
37	 * Container main class.
38	 *
39	 * @author Fabien Potencier
40	 */
41	class Container implements \ArrayAccess

If we didn’t prefix and loaded that file it would immediately throw fatal errors for class already defined.

Luckily because we do prefix, it shouldn’t cause issues, but clearly there is something occurring and this unprefixed setup is likely a factor.