Escape key does not close modal (accessibility issue) | ww.wp.xz.cn

Resolved Chris J. Zähller
(@seezee)

2 years, 11 months ago

In its current implementation, pressing the escape key to close the modal (lightbox) has no effect. This is an accessibility requirement. See https://www.magentaa11y.com/checklist-web/modal-dialog/ for testing proper implementation of modals.

The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)

Plugin Author Cristian Raiber
(@cristianraiber-1)

2 years, 11 months ago

@seezee – we’ll add this in the LITE version in the next update. Thanks for bringing this to our attention

Thread Starter Chris J. Zähller
(@seezee)

2 years, 11 months ago

Thanks for the quick response. I look forward to the update.

Thread Starter Chris J. Zähller
(@seezee)

2 years, 9 months ago

Any update on this? The current version still does not meet this accessibility requirement. It does trap focus, which is great; many similar plugins don’t. I haven’t tested whether it returns focus to the last focused item when it’s closed.

Plugin Author Cristian Raiber
(@cristianraiber-1)

2 years, 9 months ago

@seezee – the feature has been merged into the LITE version of the plugin and it will be launched soon alongside a set of new features and improvements.

Here’s a link to the code commit: https://github.com/WPChill/modula-lite/commit/32c6506ee57d3a5816494a72e7cf54b940deb5b4

We usually batch features/fixes into releases to avoid a big version bump on a minor bug fix. Typically, we aim for 2-3 month release cycles.

I hope this helps!

Thread Starter Chris J. Zähller
(@seezee)

2 years, 9 months ago

Cool; I’ll wait for the release version!

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Escape key does not close modal (accessibility issue)’ is closed to new replies.

5 replies
2 participants
Last reply from: Chris J. Zähller
Last activity: 2 years, 9 months ago
Status: resolved