Escape Label

  • Resolved Stormit

    (@stormit)


    6 years, 2 months ago

    Hello,

    We have updated your plugin to version 3.0.7. We found a problem. You escape the $label variable in the add-to-wishlist-button template. So, we can not add html to label (via the yith_wcwl_add_to_wishlist_params filter). As you can see, many themes add tooltip to button currently. We are one. We add the html of tooltip to $label. So, please consider change esc_html to wp_kses_post.

    Similar, in the add-to-wishlist-added and add-to-wishlist-browse templates, we add html via the yith-wcwl-browse-wishlist-label filter.

    Thank you!

    • This topic was modified 6 years, 2 months ago by Stormit.
Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author YITHEMES

    (@yithemes)

    6 years, 2 months ago

    Hi there
    thank you for your feedback

    The idea is that label should only contain textual content, since it comes from an option configured by the admin
    Even filtered value should just be a label, and not contain any HTML: template modifications should be made on template level

    Anyway, we want to help theme developers in any way possible with the integration of our plugin, and we understand that overriding template should be the last option; for this reason I will definitely switch to wp_kses_post in next 3.0.8 version, expected to be released within a couple of hours

    Please, feel free to check our github project, if you need to submit us techincal requests or PR

    Thread Starter Stormit

    (@stormit)

    6 years, 2 months ago

    Hello,

    I have updated your plugin to version 3.0.8. Thank you for changing!

    But, you forgot the add-to-wishlist-added and add-to-wishlist-browse templates.

    <?php echo esc_html( apply_filters( 'yith-wcwl-browse-wishlist-label', $browse_wishlist_text, $product_id, $icon ) ); ?>

    Thank you!

    Plugin Author YITHEMES

    (@yithemes)

    6 years, 2 months ago

    Noted!
    Will be changed in next version (expected release number 3.0.9)

    Thread Starter Stormit

    (@stormit)

    6 years, 2 months ago

    Hello,

    Could you please update it soon? Our customers are facing with the problem of the tooltip.

    Thank you very much!

    Plugin Author YITHEMES

    (@yithemes)

    6 years, 2 months ago

    Just published version 3.0.9, to solve the issue

    Plugin Author YITHEMES

    (@yithemes)

    6 years, 2 months ago

    Hi again

    I haven’t heard back from you in a while, so I suppose the problem is solved
    I’ll close this topic, but feel free to contact us back, whenever you need support for our plugin
    We’re very happy to help devs to integrate our plugins 🙂

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Escape Label’ is closed to new replies.