eshop_business_sec bug

EShop has an odd bit of code in paypal.php at line 66:

$eshopemailbus=$eshopoptions['business'];
if(isset( $eshopoptions['eshop_business_sec'] ) && $eshopoptions['eshop_business_sec'] !=''){
	$eshopemailbus=$eshopoptions['business_sec'];
	$_POST['business']=$eshopemailbus;
}
$checkid=md5($eshopemailbus.$token.number_format($pvalue,2));

This is odd for two reasons:

1. The conditional block is never reached because ‘eshop_business_sec’ is a typo, it should be ‘business_sec’ (see eshop-settings-extends.php)

2. It’s not clear you ever want it to be reached. It would tell PayPal to direct the payment to the secondary email address.

This whole business of using $_POST to carry around information is kind of crazy in my humble opinion. But if using it, why not just do this unconditionally:

$_POST['business']=$eshopemailbus;

(We are in the case eshopaction=’redirect’. The $_POST variable derives from the previous step, when eshopaction=’process’.)

http://ww.wp.xz.cn/extend/plugins/eshop/