External link is now broken

  • Resolved DaK888

    (@dak888)


    7 years, 1 month ago

    I have the pro version.

    I’ve implemented the solution that puts the small icon on external links. This works for most links but it does not seem to work correctly with links that open external windows via javascript.

    Here is what is happening:

    <a href="javascript:void(0)" onclick="window.open('https://www.externalsite.com/7711/visitor/window/?code_id=615&dl='+escape(document.location.href),'wsa_7711_0','height=200,width=200')" class="adaNewWindowInfo"><i class="fa fa-external-link" aria-hidden="true"></i><span class="wp_ada_hidden"> opens in a new window</span></a><span class="dakHeadLink">Link Is Here</span>

    The closing a tag for the link should appear at the end after the closing span tag for “Link Is Here” which it did before I used the plugin. Now, the a tag is being closed prematurely. How can this be fixed?

    Thanks

    • This topic was modified 7 years, 1 month ago by DaK888.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author seshelby

    (@seshelby)

    7 years, 1 month ago

    Hello, I have not been able to reproduce this issue. I entered your code and the output was as expected. Could you please provide a link to where I can view the output as well as the code as it can be seen inside your page editor. If you prefer you can send a personal message using the plugin website.

    Plugin Author seshelby

    (@seshelby)

    7 years, 1 month ago

    Issue has been resolved.

Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘External link is now broken’ is closed to new replies.