External links problem

  • Resolved themadproducer

    (@themadproducer)


    11 years, 6 months ago

    Camu…here you go…new topic plus a link to the test page.

    Basically, if I click an external link, Slimstat seems to be interfering unless I disable Slimstat. With methodical testing, here are the exact symptoms and how to reproduce them.

    – WP v4, Slimstat v3.82
    – Plugin Organizer v5.6.3
    – Chrome Browser v39.0.2171.65 m and IE-11 fail
    (Firefox 28 is NOT affected)

    Reproduce-able (90% or more of the times)
    – CLEAR BROWSER CACHE
    – go to the http://mikesqualitybodyworks.com/slimstat/
    – click the yellow NAVIGATE button and wait a few seconds
    – usually you will be redirected to one of the other internal pages
    – click the browser back button
    – click the navigate button and wait….(Nothing happens usually)
    – click it again and you should finally be directed to the external page at google maps
    – subsequent clicks of the Navigate button will work normally
    To recreate the issue, clear the browser cache and repeat the steps above

    Working pages
    The other non test pages on this website work because I have disabled slimstat on a per-page basis using “Plugin Organizer”.

    Note
    I have also tried disabling all other plugins to isolate an incompatibility without success.

    https://ww.wp.xz.cn/plugins/wp-slimstat/

Viewing 7 replies - 31 through 37 (of 37 total)
1 2 3
  • Plugin Contributor Jason Crouse

    (@coolmann)

    11 years, 6 months ago

    Hi,

    could you put this filter in the settings: do not track IP addresses that start with 108.5. (use CIDR notation). Thank you.

    bishoph

    (@bishoph)

    11 years, 6 months ago

    Hi camu. Done.

    Plugin Contributor Jason Crouse

    (@coolmann)

    11 years, 6 months ago

    bishoph, thank you for your patience. I must admit that I’m in uncharted waters. A javascript bug surfaced in 3.7.5 (related to jQuery dynamically injecting EXTERNAL links into a page), which required me to rethink part of the tracker. I am trying to read more about javascript closures and other advanced features, which I am going to use to solve the problem 🙂

    I think I am close, though.

    Plugin Contributor Jason Crouse

    (@coolmann)

    11 years, 6 months ago

    Okay, could you try to “refresh” your local install (via the version trick) one more time?

    I was able to replicate the issue on my local environment. I just released an update (you’ll need to use the version trick to get it), which rolls back all the changes introduced in 3.8.x to solve the popup blocker issue that was being triggered by the tracker on outbound links opening in a new window. This new code attempts to solve that problem in a totally different way: 3.8 was trying to emulate “clicks” on links to trick the popup blocker into opening the new window without complaining. However this solution introduced new problems of cross-browser compatibility, as you experienced.

    I went back to my previous solution, and implemented a synchronous callback as explained in

    http://stackoverflow.com/questions/9514698/bypass-popup-blocker-on-window-open-when-jquery-event-preventdefault-is-set

    I’m quite confident that this solution will now work for everybody, even if it introduces a delay in opening the popup, until the server tells the browser that the event has been properly tracked.

    Best,
    Camu

    bishoph

    (@bishoph)

    11 years, 6 months ago

    Hi camu. Quick test shows that the issue indeed is fixed. Excellent work. Thx a lot!

    One side effect is that shift-click an external link opens the link in the same window instead of a new windows (minor issue IMHO). I can create a new thread for this if you want to solve this too 🙂

    TL;DR: The external link issue is solved with current version >= 3.8.4 as of 2014-11-30.

    Plugin Contributor Jason Crouse

    (@coolmann)

    11 years, 6 months ago

    Great news, thank you so much for your patience. Yes, shift click can be fixed. I will look into that before releasing 3.8.5 to the public.

    Plugin Contributor Jason Crouse

    (@coolmann)

    11 years, 6 months ago

    One side effect is that shift-click an external link opens the link in the same window instead of a new windows (minor issue IMHO).

    This is now available in 3.8.5 as of now.

Viewing 7 replies - 31 through 37 (of 37 total)
1 2 3

The topic ‘External links problem’ is closed to new replies.