Fatal bugs!! Folder structure destroyed…

  • Resolved theojager

    (@theojager)


    8 years, 2 months ago

    Not for the first time my existing folders (partly) have been deleted.
    The Edit Folders window appears to be not fool proof (assuming I am the fool).

    Steps to reproduce:

    1. create a few main folders with sub folders and documents in those subs
    2. open the Edit folders window
    3. create a new main folder (B) and give it index 1, and a sub folder in it. Since there was already a main folder (A) with index 1 there are now TWO main folders with index 1. DON’T SAVE.
    4. remove another main folder (C) with index > 1

    Step 4 causes a HUGE problem:
    a. The 2 main folders with index 1 appear to be merged in (A).
    b. All the sub folders of main folder A are deleted.
    c. Main folder C is deleted (as expected)

    All document files can be found with option Find Lost Files, since their parent folders are deleted and they only can be assigned to existing folders I have to submit them to existing folders where they get mixed up with existing files.

    Design errors/weaknesses
    IMO, I recognize 2 design errors or at least weaknesses in this extremely important Edit folders window.
    1. the possibility to combine re-indexing the folders order and removing folders is a risky one especially for fools like I.
    2. Applying Remove to a selected folder affects the complete folder tree and not only the selected folder

    My suggestions:
    1. it should not be possible to save the tree when there are equal index numbers on the same classification level (validation rule)
    3. Removing a folder should only remove that folder but not save the complete folder tree.
    2. Removing folders should not be combined with re-indexing folders in the same window. If this has to be done in this way there should be a much stronger validation on changes before anything gets saved in the database and in the mdocs folder.

    For me, it’s now about the 3rd time that folders and even documents disappeared and I have to rebuild the structure again. Hopefully it’s the last time…

    Let me know if you need more info!

    • This topic was modified 8 years, 2 months ago by theojager.
    • This topic was modified 8 years, 2 months ago by theojager.
    • This topic was modified 8 years, 2 months ago by theojager.
Viewing 1 replies (of 1 total)
  • Plugin Author bhaldie

    (@bhaldie)

    8 years, 2 months ago

    Thank you for the detailed account of your issue. Folders have been on my todo list for almost a year now, but can get the time I need to really get the job done correctly. I am hoping this summer to get some time and finish the new folder editor.

    If you look hard enough you can see the starting of my work mdocs-folder-editor.php is the replacement editor. You can also see progress if you open the file memphis-documents.php and change the constant define('MDOCS_DEV', false); to true. The folder editor will change to the development version.

    So any way in a nutshell, I know the limitations of the current folder tool and I hope to get time this summer to get the new one finished.

    Thanks again for your input.

Viewing 1 replies (of 1 total)

The topic ‘Fatal bugs!! Folder structure destroyed…’ is closed to new replies.