Fatal Error on plugins screen

Resolved alexstandiford
(@alexstandiford)

7 months, 3 weeks ago

Hey there! We’re seeing a fatal error on the plugins screen, and it’s due to a dependency conflict between your plugin and another plugin using the same dependency. I previously discovered this on the other plugin

Here’s the error code:

PHP Fatal error: Declaration of Symfony\\Component\\Cache\\CacheItem::expiresAt(?DateTimeInterface $expiration): static must be compatible with Psr\\Cache\\CacheItemInterface::expiresAt($expiration) in /wp-content/plugins/integration-cds/vendor/symfony/cache/CacheItem.php on line 65

The issue appears to be that you are using an outdated version of this dependency.

Would it be possible for you to either scope your dependencies using Mozart, or update the dependency so that it doesn’t conflict?

Viewing 15 replies - 1 through 15 (of 16 total)

1 2 →

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 3 weeks ago

Hi @alexstandiford ,

hope you’re fine? sorry for the issue you’re facing, it’s an issue open on our side. I priorize it and come back asap with a fix

Regards
Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 3 weeks ago
I’ve check and i understand the issue. The problem is we want to keep our plugin compatible php. 7.4+ like other plugin (w3tc, yoast, etc)
psr/cache:^1.0 → works with PHP >=5.3, <=7.4.
psr/cache:^2.0 → works with PHP >=8.0.
psr/cache:^3.0 → works with avec PHP >=8.

we know php 7.4 is in end of life : https://www.php.net/supported-versions.php but a lot of user still use php 8.0 and lower

I’ll check with my team to scope it on our side and keep you in touch if we do it

regards
- This reply was modified 7 months, 3 weeks ago by Edson Galina Fortes.
Thread Starter alexstandiford
(@alexstandiford)

7 months, 3 weeks ago

Thanks Edson! If it helps, using a scoper like Mozart or PHPscoper could give you both the 7.4 compat and also ensure it doesn’t conflict.

I will stand by for an update.

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 3 weeks ago

Thanks, @alexstandiford , yes i’m still using PHPScoper for other project. I just need to check with my team what politic we want to apply. Scope or wait till we upgrade to php 8.0 compat cause in fact php 7.4 (and 8.0) are “dead”.

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 2 weeks ago

Hi @alexstandiford ,

can you try with this plugin : https://we.tl/t-Guxo5MEVf5
i’ve make a build of the plugin for php 8.2+ and it works on my side with dataverse.
Regards

Thread Starter alexstandiford
(@alexstandiford)

7 months, 2 weeks ago

Hey Edson, amazing work. Thank you for the speedy reply, I genuinely appreciate it!

This appears to have resolved the problem for us on my end, as well.

Where do we go from here? I could upload this plugin to my production site, but I suspect it needs a bit more testing, and if the next update doesn’t include this upgrade the problem will regress.

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 2 weeks ago

sorry for the disturb,

i’ve put here another version of the plugin with the “real” fix : https://we.tl/t-GA2WPdtfUT
let me explain :
The first version i send to you is a build version on php 8.2, it was a quick fix to let you enjoy the plugin haha. I’ve investigate further and find the real issue, the plugin dataverse init the plugin weglot on is admin. I’ve open an issue on my side and had code to prevent weglot load on dataverse admin page and it works.

So you can test (and install it on prod if all is ok) cause the fix would be include on the next release.

Try the plugin and get me in touch

Regards

Thread Starter alexstandiford
(@alexstandiford)

7 months, 2 weeks ago

He Edson!

Thanks for sending this! Unfortunately, I was unable to download it as the link has expired. Can you re-send please? I’ll be sure to promptly download as the link comes in this time.

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 2 weeks ago

Hi @alexstandiford ,

hope you’re fine, no problem, here the plugin : https://we.tl/t-Dtr0m9PG7p

Regards

Thread Starter alexstandiford
(@alexstandiford)

7 months, 1 week ago

Hi Edson, thank you, however when I try that version of the plugin, it gives me the fatal error again. It seems like it regressed.

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 1 week ago

Hi @alexstandiford ,
sorry it’s my fault i’ve sending the wrong package : https://we.tl/t-RMjqQUrk77
and here a short video with the proof of concept : https://www.loom.com/share/b9124562c1c84bc2a496d595ba3558c0?sid=b22d8fa1-80a0-46a6-a3d9-d92db98cbac2

let me know if it’s ok and sorry again ^^

Thread Starter alexstandiford
(@alexstandiford)

7 months, 1 week ago

Hi Edson! Thanks for your continued effort on this. I appreciate it. These things happen 😊.

I looked at the video and see that you have what’s needed to fix the problem, however when I download the new transfer file I still see the same issue on my site. Maybe the zipped package was the wrong version?

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 1 week ago

Hi @alexstandiford ,

thanks for your patience. Are you able to check if the code i show on my video is present on the package i share to you ?

Plugin Contributor Edson Galina Fortes
(@glx77)

7 months, 1 week ago

To be sure, i’ve recreate an archive you can find here : https://we.tl/t-cNobDnYYIT

Regards

Thread Starter alexstandiford
(@alexstandiford)

6 months, 2 weeks ago

Hi Edson!

Was this change included in the most recent update?

Viewing 15 replies - 1 through 15 (of 16 total)

1 2 →

You must be logged in to reply to this topic.