In a nutshell, I need to be able to have the product title underneath the QR code when they generate as PDF’s – That way I can print them directly through to my label printer!
@samuelspeed Thank you for you inputs.
This should be simple enough. I will add title on PDF print in next release. Probably in couple days.
Stay tuned.
If you can spare sometime to add 5 star review it would motivate to devote more time to this plugin’s development.
Thank you
Thank you @gangesh for getting back to me so quickly.
That would be fantastic! I will keep an eye out to see for the changes.
As soon as it has been updated, I will be more than happy to leave you a 5* review as a thank you.
Kind regards,
Sam
Hello @samuelspeed Title has been added to PDF.
Size increased as well for clarity.
Cheers!
Hi @gangesh, I have checked over your changes today and I have noticed one issue, and I have one additional visual suggestion:
Firstly – the issue is that although the variant QR codes are unique, when the PDF is generated, the product title attribute that is bought across isn’t for the corresponding variant.
For example, If I have product A, then variant A1, A2 and A3, the following is currently produced:
A – QR code for A + Title for A
A1 – QR code for A1 + Title for A
A2 – QR code for A2 + Title for A
A3 – QR code for A3 + Title for A
What it should do is the following (This is how it should work after a fix):
A – QR code for A + Title for A
A1 – QR code for A1 + Title for A1
A2 – QR code for A2 + Title for A2
A3 – QR code for A3 + Title for A3
So that will be the core functionality sorted – Then I have a visual suggestion – Could you please leave some vertical padding between the QR code and the product title when it is made into a PDF? At the moment, they are very close together which makes it difficult to read. From what I can see, I expect adding one or two additional lines of space from its current position will make the visuals 100% perfect.
If you are able to make the two changes I have advised, then this will be a 10/10 plugin right here! Really awesome work and thank you for being so proactive in making these amendments!
Kind regards,
Sam Speed
@samuelspeed Thank you for your suggestions. I will work on this as soon as I find time.
And I am not worried about 10/10 . Plugin being useful is good enough 🙂
Stay tuned.
Hi @gangesh, thank you – I look forward to seeing the changes very soon!
As soon as you have updated the plugin and it works correctly, then as promised, I will of course leave you positive feedback. I really like the plugin, it’s just a shame it still has a small bug! Apart from that, it really is a great plugin!
=D
Hi @gangesh, have you been able to fix the issue yet and make the changes I had suggested last week?
I’m happy to help you however I can?! =]
Hello @samuelspeed
Your request has been update in latest version.
Cheers!
Hi @gangesh,
I see you have corrected the issue with the variant titles, nice work!
The only remaining issue I can see with your plugin are:
1. The main QR code for a product/simple product has a ‘-‘ after the title, so ‘Product A Title’ actually shows ‘Product A Title -‘ underneath the QR code when it is generated in the PDF.
My suggested fix – I think you’ve coded it so the ‘-‘ shows by default after the main title, but it needs to only appear when a variable title is used and remain hidden at all other times.
2. On both simple and variant products, the title under the QR code currently overflows off the page if it is wider than the width of the PDF.
My suggested fix – Ideally you will need to find a way of allowing for the titles to have a fixed width when they are added to the PDF to allow for the titles to overflow vertically rather than horizontally.
I would also suggest that when you apply these fixes – try and default the layout of the titles to ‘center’ so that both simple and variant products visually look consistent and clean, no matter how long/short the product title may be.
I’m really impressed with your plugin and it is SOO SO CLOSE to working without issue. I hope that I’ve been able to message you whilst you still have this project open in the hope that you can perhaps fix these issues today if they aren’t too difficult to fix?!
Thank you so much @gangesh, I’m forever grateful for your help!
@samuelspeed
#1 Simple product is not showing “-” because its applied for Variable product only.
If you are printing QR code to Variable product and not a variation then this could be an issue.
#2 I will check alignment issue in next release. Probably more option to add like price attributes etc.
Hi @gangesh,
I’ve tried to take a look at the code myself but I’m not too great at coding. I was wondering if something along the following lines might work to fix issue #1?
In file assets / admin / js / wcqrc-product.js you could change it to show the following section of code (line 32):
if(post_type === “variable”) {
let variable_title = $(this).closest(“.woocommerce_variation”).find(” h3 > select”).find(“:selected”).text();
console.log(variable_title);
if(variable_title === “”){
post_title = post_title;
}else{
post_title = post_title + ” – ” + variable_title;
}
}
I am fairly sure this doesn’t work correctly however, but I expect you should be able to find/fix any issues pretty quickly?
If this code does help you to complete the issue with #1, could I please ask you to try and help fix issue #2 as well and perhaps try and update the plugin asap? I am still needing to use this in my current business and until issue #1 and #2 have been fixed, I am unable to use your plugin as I was hoping.
I’m more than happy to try and work with you to fix the code if you are able to show me which files will need to be altered to get the changes I am after? I can paste any amended code here too.
I just really need these two issues fixed so I can carry on with my work. I hope you can understand and I thank you so much for everything you have given me so far.
Thank you.
Hello @samuelspeed
I work as I get time on this plugin, so you will have to be little patient with it. I add features and alignment option based on general requirement and aim to add option for it as well. But as I said, I work as time allows.
Thank you for your suggestions regardless of that.
Gangesh
Hello @samuelspeed,
I have added those 2 fixes and released new version. Please update to view changes on your website.
Cheers!
Hi @gangesh,
I have updated and can see all the changes you made and it is all looking awesome!
I really appreciate all your help and correspondence with this plugin and believe that this is now a true 5* plugin!
I look forward to seeing what changes you may come up with in the future, and if you’re stuck for additional ideas, I’d always be happy to offer suggestions.
Thank you so much, once again.
Kind regards,
Sam Speed
