Feedback: boostrap.css

  • Resolved Andrew Misplon

    (@misplon)


    11 years ago

    Hi Munir

    Thanks for the contribution 🙂 My name is Andrew, I work support over at SiteOrigin and also have a couple of themes on the directory.

    Could you perhaps have a look at this plugin’s use of boostrap.css. A small example of how this is causing problem with my Ultra theme is:

    .page-header {
  padding-bottom: 9px;
  margin: 40px 0 20px;
  border-bottom: 1px solid #eee;
}

    Boostrap is targeting the page-header selector. The page-header selector is used in all Underscores (_s) based themes. This is just one example.

    Ideally the CSS for your plugin would be very specific and just target the selectors being created.

    Let me know your thoughts. Thanks for reading 🙂

    https://ww.wp.xz.cn/plugins/addon-so-widgets-bundle/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter Andrew Misplon

    (@misplon)

    11 years ago

    Perhaps a more relevant selector to look at is that bootstrap.css adds it’s own body selector including a font size, font family etc. It also has a full CSS reset section, both selectors/sections that should ideally be in theme’s control with no conflict from plugins.

    Thanks 🙂

    Plugin Author Munir Kamal

    (@munirkamal)

    11 years ago

    Hi @misplon,

    Thank you for pointing out this issue and the possible solution(s).

    Actually i am working on the next big update and i am changing many things completely such as:

    * Each widget now will have all options within it same as SiteOrigin Widget Bundle widgets.
    * Eliminate Titan framework plugin dependency.

    Moreover i will try to eliminate bootstrap also or will customize it as per the plugin need only as you suggested.

    I will hopefully do it within a week if i get enough time, so please stay tuned.

    Thanks,
    Munir

    Thread Starter Andrew Misplon

    (@misplon)

    10 years, 12 months ago

    Hi Munir

    Sorry I didn’t reply sooner, I forgot to check the email notification checkbox.

    Thanks for your reply. That’s great news! All the best with your next version, we look forward to it.

    (A quick point of feedback if you’re interested. No problem has come from this, it’s just a general feedback point. Greg suggests that if you have a moment, please look at the use of name spacing. Reference post: https://yoast.com/namespaces/).

    Chat soon 🙂 Cheers!

    Plugin Author Munir Kamal

    (@munirkamal)

    10 years, 12 months ago

    Hi Misplon,

    Thank you for your response, i will definitely look into the name spacing reference and will follow it where needed as well.

    Thakn you for taking time to followup with me on this, i will update you as soon i will have the next version ready so you may try and provide your valuable feedback.

    Cheers 🙂

    Plugin Author Munir Kamal

    (@munirkamal)

    10 years, 12 months ago

    Hi Misplon,

    As promissed i have just published the updated version of the plugin have done following updates:

    * Re-coded all Widgets to utilize SiteoRigin’s API more better.
    * Each Widget now has it’s own options, same as SiteOrigin’s Widget bundle widgets.
    * Each Widget now can be styled differently as each one has it’s own styling options as well.
    * Removed Titan Framework Dependency.
    * Customized bootstrap css used to just use the bootstap Grid CSS, excluded all other css from Bootstrap css file.
    * Fixed some small bugs as well.

    I would request you to please test and let me know your feedbacks with this new updated plugin.

    Note: This is a major update and once updated you might notice that active widgets do not work properly, you simply need to re-add those widgets on page and they will work.

    Thanks,
    Munir

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘Feedback: boostrap.css’ is closed to new replies.

Tags