Fix for PHP Strict Notices

  • Resolved gausie

    (@gausie)


    12 years, 5 months ago

    Hi there,

    If you set WordPress to debug mode, there are a couple of instances where you feed get_posts() to reset(), which triggers a notice as reset expects to receive a variable not a function (I know, stupid right?).

    Anyway, it’s a quick fix with something like

    $get_posts = get_posts(...);
reset($get_posts);

    in both instances. Would be happy to fix myself – maybe consider putting the plugin on github?

    http://ww.wp.xz.cn/plugins/menu-image/

Viewing 6 replies - 1 through 6 (of 6 total)
  • zviryatko

    (@zviryatko)

    12 years, 5 months ago

    Hi

    I know about errors, so I sorry for that. I’ll fix it, promise!

    And I would gladly move to git from svn (’cause SVN brings me pain!), but w.org required to work throught svn =(

    I know that I already can use git-svn-diff, but it’s more work…

    Oh… live once… I think it’s a good idea, so I’ll copy source code to github.

    Thread Starter gausie

    (@gausie)

    12 years, 5 months ago

    Haha!

    Let me know and I’ll submit some PRs! I’ve got a few things I think would improve the plugin…

    zviryatko

    (@zviryatko)

    12 years, 5 months ago

    Good news, everyone!

    I finally found time to transfer repo to github, now I hate svn much more, new link for source https://github.com/zviryatko/menu-image.

    And yesterday one man sent to me modified sources of menu-image with media uploader integration, currently I didn’t looked to his code, but I think it should work.

    Thread Starter gausie

    (@gausie)

    12 years, 5 months ago

    Great! Where is that code?

    zviryatko

    (@zviryatko)

    12 years, 5 months ago

    In my mail box, waiting for review. I can forward to you, send me something on [email protected]

    Thread Starter gausie

    (@gausie)

    12 years, 5 months ago

    Cool – why not throw it into a new branch on git? Or I can do it. Emailing you now.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘Fix for PHP Strict Notices’ is closed to new replies.