Fixing no space before parenthesis

  • spiros

    (@spiros)


    8 years, 6 months ago

    In order to fix lack of space before parenthesis of link count in category change line 123 in bms-linksshow.php to:

    $output.='<td>' . $link . ' (' . $category->count . ')' . '</td>';

    To add no follow, change line 66 to:

    $output .= '<td>' . the_title('<a target="_blank" rel="nofollow" href="' . $linkurl . '">', '</a>', false) . '</td>';

    • This topic was modified 8 years, 6 months ago by spiros.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author MaikelM

    (@maikelm)

    8 years, 6 months ago

    Great input! Thank you. I was never aware that the lack of space for the link count was an issue. Since this is a breaking (visual) change when applied, I am not sure I will implement it on the next update.
    The ‘nofollow’ is a brain breaker. I think one should use it for user supplied forum content or comments on blogs. But the ‘nofollow’is a biased SEO discussion. Why not use it when your links are valuable and you do not mind extra (bot)traffic to the sites in your link library?

    Thread Starter spiros

    (@spiros)

    8 years, 6 months ago

    Lack of space before parenthesis is against(typography) rules (you catch my point from the intentional error).

    I think nofollow should be at the very least, an option (preferably, also, on a link by link basis).
    Moreover, perhaps some css styling could help improve the visual aspect of the plugin. Also, it would be good if a default category of links was expanded. Currently, one has to click on a category to see any links.

    Translation readiness is a third possible improvement.

    Another option would be to have all links expanded in all categories (but grouped on categories, i.e. like this: https://porfiras.wordpress.com/links/ )

    • This reply was modified 8 years, 6 months ago by spiros.
    • This reply was modified 8 years, 6 months ago by spiros.
    • This reply was modified 8 years, 6 months ago by spiros.
Viewing 2 replies - 1 through 2 (of 2 total)

The topic ‘Fixing no space before parenthesis’ is closed to new replies.