Hi enollo,
For now I don’t have plans to create a Repo for this plugin. I want to keep support on one place as long as possible.
If you have an issue please post it here, or you can send me an e-mail (may include code).
But thanks for the thoughts 🙂
Thread Starter
enollo
(@enollo)
Hi Sormano,
That’s unfortunate but understandable.
I ran into an issue with the Genesis framework, seeing the following notices:
NOTICE: UNDEFINED PROPERTY: STDCLASS::$TERM_ID IN /.../.../WOOCOMMERCE-PRODUCTS-PER-PAGE/OBJECTS/WPPP-DROPDOWN.PHP ON LINE 30
NOTICE: UNDEFINED INDEX: BEHAVIOUR IN /.../.../WOOCOMMERCE-PRODUCTS-PER-PAGE/OBJECTS/WPPP-DROPDOWN.PHP ON LINE 32
NOTICE: UNDEFINED VARIABLE: ACTION IN /.../.../WOOCOMMERCE-PRODUCTS-PER-PAGE/OBJECTS/WPPP-DROPDOWN.PHP ON LINE 40
These do not show up with two other themes I have tested it with so I assume it might be Genesis specific. Either way, changing the if/esleif in wppp_create_object() a bit helped:
$action = '';
if ( isset($cat->term_id) && true == $cat->term_id && isset($this->options['behaviour']) && true == $this->options['behaviour'] && isset($cat->taxonomy) && 'product_cat' == $cat->taxonomy ) :
$action = ' action="' . get_term_link( $cat->term_id, 'product_cat' ) . $query_string . '"';
elseif ( isset($this->options['behaviour']) && true == $this->options['behaviour'] ) :
$action = 'action="' . get_permalink( woocommerce_get_page_id( 'shop' ) ) . $query_string . '"';
endif;
Cheers,
Tamara
Hi Tamara,
Thanks for taking the time to figure it out.
I’ve contacted the guys of Genesis to see why this only appears in Genesis.
I will probably put an update out this weekend with your fix (if i’ve gotten an answer of genesis 🙂 ).
I do believe it is unusual to get notices on live websites? Do you have WP_DEBUG on?
Greets,
Jeroen
Thread Starter
enollo
(@enollo)
Hi Jeroen,
I’m actually developing a website for a client so it is quite normal that I see notices 🙂
Thanks for looking into this. Let me know what they say.
Cheers,
Tamara
Hi Tamara,
Just released an update (1.0.10) with fixes with notices with debug mode on.
Let me know how that works out for you.
Greets,
Jeroen
Thread Starter
enollo
(@enollo)
Hi Jeroen,
It works great! Thank you.
I’m curious, did you find out why it was Genesis specific?
Thanks,
Tamara
Hi Tamara,
I did not go into full detail why its visible on Genesis, my guess is that either Genesis or Twenty Twelve (dev theme is use) has some STRICT settings different or something.
Greets,
Jeroen
